Sign upLogin

wadmiraal/drupal8_tdd_form_validation

View on GitHub
Star

Showing 4 of 4 total issues

Method submitForm has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function submitForm(array &$form, FormStateInterface $form_state) {
    if ($form_state->getValue('reset')) {
      $node_storage = \Drupal::entityTypeManager()->getStorage('node');
      $nids = \Drupal::entityQuery('node')
        ->condition('type', 'book')
Severity: Minor
Found in src/Form/BookImportForm.php - About 1 hr to fix

    Method buildForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function buildForm(array $form, FormStateInterface $form_state) {
    $form['csv'] = [
      '#type' => 'managed_file',
      '#title' => $this->t("Book list"),
      '#upload_validators' => [
    Severity: Minor
    Found in src/Form/BookImportForm.php - About 1 hr to fix

      Function submitForm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        public function submitForm(array &$form, FormStateInterface $form_state) {
    if ($form_state->getValue('reset')) {
      $node_storage = \Drupal::entityTypeManager()->getStorage('node');
      $nids = \Drupal::entityQuery('node')
        ->condition('type', 'book')
      Severity: Minor
      Found in src/Form/BookImportForm.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public function validate(FileInterface $file) {
    $rows = $this->parseFile($file);

    // Analyze the file format. We should get 2 columns.
    $row = array_shift($rows);
      Severity: Minor
      Found in src/CsvParser.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language