Sign upLogin

wadmiraal/wind

View on GitHub
Star

Showing 16 of 16 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetLogLevelFromRoute()
    {
        $router = new Router();
        $this->assertEquals(LogLevel::EMERGENCY, $router->getLogLevelFromRoute(Router::EMERGENCY), "Emergency route level does not match.");
        $this->assertEquals(LogLevel::ALERT, $router->getLogLevelFromRoute(Router::ALERT), "Alert route level does not match.");
Severity: Major
Found in src/Wind/Tests/Server/RouterTest.php and 1 other location - About 7 hrs to fix
src/Wind/Tests/Server/RouterTest.php on lines 23..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 231.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGetRouteFromLogLevel()
    {
        $router = new Router();
        $this->assertEquals(Router::EMERGENCY, $router->getRouteFromLogLevel(LogLevel::EMERGENCY), "Emergency route level does not match.");
        $this->assertEquals(Router::ALERT, $router->getRouteFromLogLevel(LogLevel::ALERT), "Alert route level does not match.");
Severity: Major
Found in src/Wind/Tests/Server/RouterTest.php and 1 other location - About 7 hrs to fix
src/Wind/Tests/Server/RouterTest.php on lines 51..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 231.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getRouteFromLogLevel($level)
    {
        switch ($level) {
            case LogLevel::EMERGENCY:
                return self::EMERGENCY;
Severity: Major
Found in src/Wind/Server/Router.php and 1 other location - About 2 hrs to fix
src/Wind/Server/Router.php on lines 98..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getLogLevelFromRoute($route)
    {
        switch ($route) {
            case self::EMERGENCY:
                return LogLevel::EMERGENCY;
Severity: Major
Found in src/Wind/Server/Router.php and 1 other location - About 2 hrs to fix
src/Wind/Server/Router.php on lines 62..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getRequestedPath has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRequestedPath()
    {
        if (!empty($_SERVER['REQUEST_URI'])) {
            $uri = $_SERVER['REQUEST_URI'];
Severity: Minor
Found in src/Wind/Server/Router.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method testLogging has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testLogging() 
    {
        $log_file = dirname(__FILE__) . '/../../../bin/log.log';

        $ch = curl_init($this->server);
Severity: Minor
Found in src/Wind/Tests/bin/LiveTest.php - About 1 hr to fix

    Method getRequestedPath has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getRequestedPath()
    {
        if (!empty($_SERVER['REQUEST_URI'])) {
            $uri = $_SERVER['REQUEST_URI'];
    Severity: Minor
    Found in src/Wind/Server/Router.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return self::NOTICE;
      Severity: Major
      Found in src/Wind/Server/Router.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return self::DEBUG;
        Severity: Major
        Found in src/Wind/Server/Router.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return LogLevel::WARNING;
          Severity: Major
          Found in src/Wind/Server/Router.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return LogLevel::INFO;
            Severity: Major
            Found in src/Wind/Server/Router.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return LogLevel::NOTICE;
              Severity: Major
              Found in src/Wind/Server/Router.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return self::WARNING;
                Severity: Major
                Found in src/Wind/Server/Router.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return LogLevel::DEBUG;
                  Severity: Major
                  Found in src/Wind/Server/Router.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return self::INFO;
                    Severity: Major
                    Found in src/Wind/Server/Router.php - About 30 mins to fix

                      Function testLogging has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function testLogging() 
    {
        $log_file = dirname(__FILE__) . '/../../../bin/log.log';

        $ch = curl_init($this->server);
                      Severity: Minor
                      Found in src/Wind/Tests/bin/LiveTest.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language