Sign upLogin

waiterio/api

View on GitHub
Star

Showing 569 of 569 total issues

Function getLogger has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getLogger() {
    const loggerObject = new (winston.Logger)({
        levels: {
            trace: 0,
            debug: 1,
Severity: Minor
Found in common/logging.js - About 1 hr to fix

    Function getRepo has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports.getRepo = function(db) {
    return {
        addRecord: function(queryOptions, dbData, callback) {
            const preparedOptions = dbHelpers.prepareQueryOptions(queryOptions);
            const dbQuery = `INSERT INTO ${preparedOptions.table} ${dbData.fieldQuery} VALUES ${dbData.valueQuery}`.trim();
    Severity: Minor
    Found in common/databaseRepository.js - About 1 hr to fix

      Function addOrder has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports.addOrder = function(req, res) {
    const orderItems = req.body.orderitems;
    const orderData = [
        { field: 'notes', input: req.body.notes, rules: { notEmpty: false, type: 'string' } },
        { field: 'ordertimestamp', input: new Date().getTime().toString(), rules: { notEmpty: true, type: 'string' } },
      Severity: Minor
      Found in api/orders/ordersPost.js - About 1 hr to fix

        Function prepareQueryOptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports.prepareQueryOptions = function(queryOptions) {
    const preparedQueryOptions = queryOptions;

    if (typeof preparedQueryOptions !== 'undefined' && preparedQueryOptions !== null) {
        if (typeof queryOptions.fields === 'undefined') {
        Severity: Minor
        Found in common/databaseHelpers.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function(req, res, next) {
    req.app.get('log').route(`${req.method} ${req.originalUrl}`);

    const accessToken = (req.body && req.body.access_token) || req.headers[ 'access-token' ];
        Severity: Minor
        Found in auth/validateRequest.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function(options) {
    options.database = (process.env.DATABASE || options.database);

    if (options.environment === 'production') {
        sqlite = require('sqlite3').cached;
        Severity: Minor
        Found in common/sqlite.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getLimitQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports.getLimitQuery = function(limitNumber) {
    if (typeof limitNumber !== 'undefined') {
        if (!isNaN(limitNumber)) {
            let limit = parseInt(limitNumber, 10);
        Severity: Minor
        Found in common/databaseHelpers.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Unexpected tab character.
        Open

            }
        Severity: Minor
        Found in auth/validateRequest.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Expected to return a value at the end of function.
        Open

        module.exports.removeCategory = function(req, res) {
        Severity: Minor
        Found in api/categories/categoriesDelete.js by eslint

        require return statements to either always or never specify values (consistent-return)

        Unlike statically-typed languages which enforce that a function returns a specified type of value, JavaScript allows different code paths in a function to return different types of values.

        A confusing aspect of JavaScript is that a function returns undefined if any of the following are true:

        • it does not execute a return statement before it exits
        • it executes return which does not specify a value explicitly
        • it executes return undefined
        • it executes return void followed by an expression (for example, a function call)
        • it executes return followed by any other expression which evaluates to undefined

        If any code paths in a function return a value explicitly but some code path do not return a value explicitly, it might be a typing mistake, especially in a large function. In the following example:

        • a code path through the function returns a Boolean value true
        • another code path does not return a value explicitly, therefore returns undefined implicitly
        function doSomething(condition) {
    if (condition) {
        return true;
    } else {
        return;
    }
}

        Rule Details

        This rule requires return statements to either always or never specify values. This rule ignores function definitions where the name begins with an uppercase letter, because constructors (when invoked with the new operator) return the instantiated object implicitly if they do not return another object explicitly.

        Examples of incorrect code for this rule:

        /*eslint consistent-return: "error"*/

function doSomething(condition) {
    if (condition) {
        return true;
    } else {
        return;
    }
}

function doSomething(condition) {
    if (condition) {
        return true;
    }
}

        Examples of correct code for this rule:

        /*eslint consistent-return: "error"*/

function doSomething(condition) {
    if (condition) {
        return true;
    } else {
        return false;
    }
}

function Foo() {
    if (!(this instanceof Foo)) {
        return new Foo();
    }

    this.a = 0;
}

        Options

        This rule has an object option:

        • "treatUndefinedAsUnspecified": false (default) always either specify values or return undefined implicitly only.
        • "treatUndefinedAsUnspecified": true always either specify values or return undefined explicitly or implicitly.

        treatUndefinedAsUnspecified

        Examples of incorrect code for this rule with the default { "treatUndefinedAsUnspecified": false } option:

        /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": false }]*/

function foo(callback) {
    if (callback) {
        return void callback();
    }
    // no return statement
}

function bar(condition) {
    if (condition) {
        return undefined;
    }
    // no return statement
}

        Examples of incorrect code for this rule with the { "treatUndefinedAsUnspecified": true } option:

        /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/

function foo(callback) {
    if (callback) {
        return void callback();
    }
    return true;
}

function bar(condition) {
    if (condition) {
        return undefined;
    }
    return true;
}

        Examples of correct code for this rule with the { "treatUndefinedAsUnspecified": true } option:

        /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/

function foo(callback) {
    if (callback) {
        return void callback();
    }
    // no return statement
}

function bar(condition) {
    if (condition) {
        return undefined;
    }
    // no return statement
}

        When Not To Use It

        If you want to allow functions to have different return behavior depending on code branching, then it is safe to disable this rule. Source: http://eslint.org/docs/rules/

        Unexpected tab character.
        Open

            const validationResult = validator.validate(categoryData);
        Severity: Minor
        Found in api/categories/categoriesDelete.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

                return res.status(validationResult.statusCode).json({ status: validationResult.statusCode, message: validationResult.message });
        Severity: Minor
        Found in api/categories/categoriesDelete.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            const categoryId = parseInt(req.params.id, 10);
        Severity: Minor
        Found in api/categories/categoriesGet.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            ];
        Severity: Minor
        Found in api/categories/categoriesPost.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            });
        Severity: Minor
        Found in api/dishes/dishesGet.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            res.status(501).json({ status: 501, message: 'Not implemented' });
        Severity: Minor
        Found in auth/router.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

                    decodedUserInfo = jsonWebToken.decode(accessToken, settings.secret, false);
        Severity: Minor
        Found in auth/validateRequest.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            const categoryData = [
        Severity: Minor
        Found in api/categories/categoriesDelete.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            ];
        Severity: Minor
        Found in api/categories/categoriesDelete.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

                return res.status(validationResult.statusCode).json({ status: validationResult.statusCode, message: validationResult.message });
        Severity: Minor
        Found in api/categories/categoriesPost.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Unexpected tab character.
        Open

            if (validationResult.status === true) {
        Severity: Minor
        Found in api/categories/categoriesPut.js by eslint

        disallow all tabs (no-tabs)

        Some style guides don't allow the use of tab characters at all, including within comments.

        Rule Details

        This rule looks for tabs anywhere inside a file: code, comments or anything else.

        Examples of incorrect code for this rule:

        var a /t= 2;

/**
* /t/t it's a test function
*/
function test(){}

var x = 1; // /t test

        Examples of correct code for this rule:

        var a = 2;

/**
* it's a test function
*/
function test(){}

var x = 1; // test

        When Not To Use It

        If you have established a standard where having tabs is fine.

        Compatibility

        Severity
        Category
        Status
        Source
        Language