Sign upLogin

wakelank/Tinsl

View on GitHub
Star

Showing 833 of 833 total issues

File seeds.rb has 1407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

arr = [
    
    {
      title: {
        text: "Gone with the Wind",
Severity: Major
Found in seeds.rb - About 3 days to fix

    Assignment Branch Condition size for ranking is too high. [40.83/15]
    Open

      def ranking
    ranking = {}
    rank = 0
    arr = []
    Severity: Minor
    Found in app/models/movie.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Method has too many lines. [34/10]
    Open

      def ranking
    ranking = {}
    rank = 0
    arr = []
    Severity: Minor
    Found in app/models/movie.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [14/10]
    Open

      def create
      if params[:guest] then
          email = "guest@example.com"
          password = "password"
      else
    Severity: Minor
    Found in app/controllers/sessions_controller.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Assignment Branch Condition size for get_image is too high. [17.58/15]
    Open

      def get_image
    if self.image_url.nil?
      base_url="http://private-e8bc0-themoviedb.apiary-proxy.com/3/search/person?api_key="
      key=ENV.fetch('TMDB_KEY')
      search = self.name.gsub!(" ","+") || self.name
    Severity: Minor
    Found in app/models/actor.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for create is too high. [16.43/15]
    Open

      def create
      if params[:guest] then
          email = "guest@example.com"
          password = "password"
      else
    Severity: Minor
    Found in app/controllers/sessions_controller.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Method has too many lines. [11/10]
    Open

      def get_image
    if self.image_url.nil?
      base_url="http://private-e8bc0-themoviedb.apiary-proxy.com/3/search/person?api_key="
      key=ENV.fetch('TMDB_KEY')
      search = self.name.gsub!(" ","+") || self.name
    Severity: Minor
    Found in app/models/actor.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Assignment Branch Condition size for generate_title is too high. [15.26/15]
    Open

          def generate_title
        adj_url="http://api.wordnik.com:80/v4/words.json/randomWords?hasDictionaryDef=false&includePartOfSpeech=adjective&minCorpusCount=0&maxCorpusCount=-1&minDictionaryCount=1&maxDictionaryCount=-1&minLength=5&maxLength=-1&limit=1&api_key="
        noun_url="http://api.wordnik.com:80/v4/words.json/randomWords?hasDictionaryDef=false&includePartOfSpeech=noun&minCorpusCount=0&maxCorpusCount=-1&minDictionaryCount=1&maxDictionaryCount=-1&minLength=5&maxLength=-1&limit=1&api_key="
        key=ENV.fetch('WORDNIK_KEY')
    Severity: Minor
    Found in app/controllers/movies_controller.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Method ranking has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def ranking
    ranking = {}
    rank = 0
    arr = []
    Severity: Minor
    Found in app/models/movie.rb - About 1 hr to fix

      Method ranking has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def ranking
    ranking = {}
    rank = 0
    arr = []
      Severity: Minor
      Found in app/models/movie.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Use delete instead of gsub.
      Open

        x = x.gsub(',','')
      Severity: Minor
      Found in seeds.rb by rubocop

      This cop identifies places where gsub can be replaced by tr or delete.

      Example:

      # bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

            gross: "$1,417,832,000"
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

              text: "E.T.: The Extra-Terrestrial",
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

            gross: "$867,640,000"
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

            gross: "$780,080,000"
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

              text: "The Graduate",
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Prefer single-quoted strings when you don't need string interpolation or special symbols.
      Open

              text: "Independence Day",
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

      Extra blank line detected.
      Open
      Severity: Minor
      Found in seeds.rb by rubocop

      This cops checks for two or more consecutive blank lines.

      Example:

      # bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

      Space missing after comma.
      Open

        x = x.gsub(',','')
      Severity: Minor
      Found in seeds.rb by rubocop

      Checks for comma (,) not followed by some kind of space.

      Example:

      # bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

      Trailing whitespace detected.
      Open
      Severity: Minor
      Found in seeds.rb by rubocop
      Severity
      Category
      Status
      Source
      Language