waku-org/go-waku

View on GitHub
examples/chat2/exec.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function execute has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func execute(options Options) {
    var err error
    hostAddr, _ := net.ResolveTCPAddr("tcp", fmt.Sprintf("0.0.0.0:%d", options.Port))

    if options.NodeKey == nil {
Severity: Major
Found in examples/chat2/exec.go - About 2 hrs to fix

    Function execute has 7 return statements (exceeds 4 allowed).
    Open

    func execute(options Options) {
        var err error
        hostAddr, _ := net.ResolveTCPAddr("tcp", fmt.Sprintf("0.0.0.0:%d", options.Port))
    
        if options.NodeKey == nil {
    Severity: Major
    Found in examples/chat2/exec.go - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if options.RLNRelay.Enable {
              spamHandler := func(message *pb.WakuMessage, topic string) error {
                  return nil
              }
      
      
      Severity: Major
      Found in examples/chat2/exec.go and 1 other location - About 1 hr to fix
      examples/chat2-reliable/exec.go on lines 46..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 171.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status