waku-org/go-waku

Function generateSecureRandomData has 6 return statements (exceeds 4 allowed).

Open

func generateSecureRandomData(length int) ([]byte, error) {
    x := make([]byte, length)
    y := make([]byte, length)
    res := make([]byte, length)

Function DecodeSymmetric has 6 return statements (exceeds 4 allowed).

Open

func DecodeSymmetric(messageJSON string, symmetricKey string) (string, error) {
    var msg pb.WakuMessage
    err := json.Unmarshal([]byte(messageJSON), &msg)
    if err != nil {
        return "", err

Function buildTransactor has 6 return statements (exceeds 4 allowed).

Open

func buildTransactor(ctx context.Context, membershipFee *big.Int, chainID *big.Int) (*bind.TransactOpts, error) {
    auth, err := bind.NewKeyedTransactorWithChainID(options.ETHPrivateKey, chainID)
    if err != nil {
        return nil, err
    }

Method WakuLightPush.request has 6 return statements (exceeds 4 allowed).

Open

func (wakuLP *WakuLightPush) request(ctx context.Context, req *pb.PushRequest, params *lightPushRequestParameters, peerID peer.ID) (*pb.PushResponse, error) {

    logger := wakuLP.log.With(logging.HostID("peer", peerID))

    stream, err := wakuLP.h.NewStream(ctx, peerID, LightPushID_v20beta1)

Function execute has 6 return statements (exceeds 4 allowed).

Open

func execute(ctx context.Context) error {
    rlnInstance, err := rln.NewRLN()
    if err != nil {
        return err
    }

Method WakuMetadata.Connected has 6 return statements (exceeds 4 allowed).

Open

func (wakuM *WakuMetadata) Connected(n network.Network, cc network.Conn) {
    go func() {
        defer utils.LogOnPanic()
        wakuM.log.Debug("peer connected", zap.Stringer("peer", cc.RemotePeer()))
        // Metadata verification is done only if a clusterID is specified

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    for _, m := range messages {
        s.subDetails = append(s.subDetails, s.getSub(m.PubSubTopic, m.ContentTopic, s.FullNodeHost.ID())...)
        _, err = s.relayNode.Subscribe(context.Background(), protocol.NewContentFilter(m.PubSubTopic))
        s.Require().NoError(err)
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    for _, m := range messages {
        s.subDetails = append(s.subDetails, s.getSub(m.PubSubTopic, m.ContentTopic, s.FullNodeHost.ID())...)
        _, err = s.relayNode.Subscribe(context.Background(), protocol.NewContentFilter(m.PubSubTopic))
        s.Require().NoError(err)
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

type UI struct {
    ready bool
    err   error

    quitChan  chan struct{}

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

type UI struct {
    ready bool
    err   error

    quitChan  chan struct{}

• Read up
  Read up

Method PeerManager.DiscoverAndConnectToPeers has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (pm *PeerManager) DiscoverAndConnectToPeers(ctx context.Context, cluster uint16,
    shard uint16, serviceProtocol protocol.ID, maxCount int) error {

Method PeerManager.addPeer has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (pm *PeerManager) addPeer(ID peer.ID, addrs []ma.Multiaddr, origin wps.Origin, pubSubTopics []string, protocols ...protocol.ID) error {

Function createHostWithDiscv5AndPM has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func createHostWithDiscv5AndPM(t *testing.T, hostName string, topic string, enrField uint8, bootnode ...*enode.Node) (host.Host, *PeerManager, *discv5.DiscoveryV5) {

Method PeerManager.discoverOnDemand has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (pm *PeerManager) discoverOnDemand(cluster uint16,
    shard uint16, wakuProtocol protocol.ID, ctx context.Context, maxCount int) ([]service.PeerData, error) {

Function WaitForTimeout has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func WaitForTimeout(t *testing.T, ctx context.Context, timeout time.Duration, wg *sync.WaitGroup, ch chan *protocol.Envelope) {

Function NewMissingMessageVerifier has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewMissingMessageVerifier(storenodeRequester common.StorenodeRequestor, messageTracker MessageTracker, timesource timesource.Timesource, logger *zap.Logger, options ...MissingMessageVerifierOption) *MissingMessageVerifier {

Method defaultStorenodeMessageVerifier.MessageHashesExist has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (d *defaultStorenodeMessageVerifier) MessageHashesExist(ctx context.Context, requestID []byte, peerID peer.ID, pageSize uint64, messageHashes []pb.MessageHash) ([]pb.MessageHash, error) {

Method MissingMessageVerifier.fetchMessagesBatch has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (m *MissingMessageVerifier) fetchMessagesBatch(c chan<- *protocol.Envelope, interest criteriaInterest, batchFrom int, batchTo int, now time.Time) error {

Function NewConnectionNotifier has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewConnectionNotifier(ctx context.Context, h host.Host, connNotifCh chan<- PeerConnection, metrics Metrics, log *zap.Logger) ConnectionNotifier {

Method Rendezvous.DiscoverShard has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (r *Rendezvous) DiscoverShard(ctx context.Context, rp *RendezvousPoint, cluster uint16, shard uint16, numPeers int) {