waku-org/go-waku

View on GitHub
library/node.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function NewNode has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewNode(instance *WakuInstance, configJSON string) error {
    if err := validateInstance(instance, NotConfigured); err != nil {
        return err
    }

Severity: Major
Found in library/node.go - About 2 hrs to fix

    Function NewNode has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
    Open

    func NewNode(instance *WakuInstance, configJSON string) error {
        if err := validateInstance(instance, NotConfigured); err != nil {
            return err
        }
    
    
    Severity: Minor
    Found in library/node.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function NewNode has 12 return statements (exceeds 4 allowed).
    Open

    func NewNode(instance *WakuInstance, configJSON string) error {
        if err := validateInstance(instance, NotConfigured); err != nil {
            return err
        }
    
    
    Severity: Major
    Found in library/node.go - About 1 hr to fix

      Function validateInstance has 7 return statements (exceeds 4 allowed).
      Open

      func validateInstance(instance *WakuInstance, validationType ValidationType) error {
          if instance == nil {
              return errWakuNodeNotReady
          }
      
      
      Severity: Major
      Found in library/node.go - About 45 mins to fix

        Function Start has 5 return statements (exceeds 4 allowed).
        Open

        func Start(instance *WakuInstance) error {
            if err := validateInstance(instance, MustBeStopped); err != nil {
                return err
            }
        
        
        Severity: Major
        Found in library/node.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status