Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/discv5/discover_test.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function TestDiscV5WithShardFilter has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestDiscV5WithShardFilter(t *testing.T) {

    // Following topic syntax for shard /waku/2/rs/<cluster_id>/<shard_number>
    pubSubTopic := "/waku/2/rs/10/1"
Severity: Minor
Found in waku/v2/discv5/discover_test.go - About 1 hr to fix

    Function TestDiscV5 has 62 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestDiscV5(t *testing.T) {
    // Host1 <-> Host2 <-> Host3
    // Host4(No waku capabilities) <-> Host2

    // H1
    Severity: Minor
    Found in waku/v2/discv5/discover_test.go - About 1 hr to fix

      Function TestDiscV5WithCapabilitiesFilter has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestDiscV5WithCapabilitiesFilter(t *testing.T) {

    // H1
    host1, _, prvKey1 := tests.CreateHost(t)
    udpPort1, err := tests.FindFreeUDPPort(t, "127.0.0.1", 3)
      Severity: Minor
      Found in waku/v2/discv5/discover_test.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func TestRecordErrorIteratorFailure(t *testing.T) {

    m := newMetrics(prometheus.DefaultRegisterer)

    // Increment error counter for rateLimitFailure 7 times
        Severity: Major
        Found in waku/v2/discv5/discover_test.go and 1 other location - About 1 hr to fix
        waku/v2/protocol/peer_exchange/waku_peer_exchange_test.go on lines 418..438

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 151.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status