Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/node/wakunode2_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function Test500 has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Test500(t *testing.T) {
    maxMsgs := 500
    maxMsgBytes := int2Bytes(maxMsgs)

    ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
Severity: Major
Found in waku/v2/node/wakunode2_test.go - About 2 hrs to fix

    Function Test500 has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func Test500(t *testing.T) {
    maxMsgs := 500
    maxMsgBytes := int2Bytes(maxMsgs)

    ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
    Severity: Minor
    Found in waku/v2/node/wakunode2_test.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TestStaticShardingLimits has 75 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestStaticShardingLimits(t *testing.T) {

    log := utils.Logger()

    if os.Getenv("RUN_FLAKY_TESTS") != "true" {
    Severity: Minor
    Found in waku/v2/node/wakunode2_test.go - About 2 hrs to fix

      Function TestDecoupledStoreFromRelay has 75 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestDecoupledStoreFromRelay(t *testing.T) {
    ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
    defer cancel()

    // NODE1: Relay Node + Filter Server
      Severity: Minor
      Found in waku/v2/node/wakunode2_test.go - About 2 hrs to fix

        Function TestStaticShardingMultipleTopics has 61 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestStaticShardingMultipleTopics(t *testing.T) {
    ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
    defer cancel()

    testClusterID := uint16(20)
        Severity: Minor
        Found in waku/v2/node/wakunode2_test.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              go func() {
        defer wg.Done()

        ticker := time.NewTimer(30 * time.Second)
        defer ticker.Stop()
          Severity: Major
          Found in waku/v2/node/wakunode2_test.go and 1 other location - About 1 hr to fix
          waku/v2/node/wakunode2_test.go on lines 193..212

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 138.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              go func() {
        defer wg.Done()

        ticker := time.NewTimer(30 * time.Second)
        defer ticker.Stop()
          Severity: Major
          Found in waku/v2/node/wakunode2_test.go and 1 other location - About 1 hr to fix
          waku/v2/node/wakunode2_test.go on lines 172..191

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 138.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status