Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/peermanager/fastest_peer_selector.go

Summary

Maintainability
A
3 hrs
Test Coverage
A
92%

Method FastestPeerSelector.FastestPeer has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *FastestPeerSelector) FastestPeer(ctx context.Context, peers peer.IDSlice) (peer.ID, error) {
    var peerRTT []pingResult
    var peerRTTMutex sync.Mutex

    wg := sync.WaitGroup{}
Severity: Minor
Found in waku/v2/peermanager/fastest_peer_selector.go - About 1 hr to fix

    Method FastestPeerSelector.FastestPeer has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func (r *FastestPeerSelector) FastestPeer(ctx context.Context, peers peer.IDSlice) (peer.ID, error) {
    var peerRTT []pingResult
    var peerRTTMutex sync.Mutex

    wg := sync.WaitGroup{}
    Severity: Minor
    Found in waku/v2/peermanager/fastest_peer_selector.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status