Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/peermanager/peer_selection.go

Summary

Maintainability
A
2 hrs
Test Coverage
B
82%

Method PeerManager.selectServicePeer has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func (pm *PeerManager) selectServicePeer(criteria PeerSelectionCriteria) (PeerSet, error) {
    peers := make(PeerSet)
    var err error
    for retryCnt := 0; retryCnt < 1; retryCnt++ {
        //Try to fetch from serviceSlot
Severity: Minor
Found in waku/v2/peermanager/peer_selection.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PeerManager.SelectRandom has 5 return statements (exceeds 4 allowed).
Open

func (pm *PeerManager) SelectRandom(criteria PeerSelectionCriteria) (peer.IDSlice, error) {
    // @TODO We need to be more strategic about which peers we dial. Right now we just set one on the service.
    // Ideally depending on the query and our set  of peers we take a subset of ideal peers.
    // This will require us to check for various factors such as:
    //  - which topics they track
Severity: Major
Found in waku/v2/peermanager/peer_selection.go - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status