Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/protocol/legacy_store/waku_store_client.go

Summary

Maintainability
C
1 day
Test Coverage
B
81%

Method WakuStore.Query has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Open

func (store *WakuStore) Query(ctx context.Context, query Query, opts ...HistoryRequestOption) (*Result, error) {
    params := new(HistoryRequestParameters)
    params.s = store

    optList := DefaultOptions()
Severity: Minor
Found in waku/v2/protocol/legacy_store/waku_store_client.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method WakuStore.Query has 105 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (store *WakuStore) Query(ctx context.Context, query Query, opts ...HistoryRequestOption) (*Result, error) {
    params := new(HistoryRequestParameters)
    params.s = store

    optList := DefaultOptions()
Severity: Major
Found in waku/v2/protocol/legacy_store/waku_store_client.go - About 3 hrs to fix

    Method WakuStore.Query has 9 return statements (exceeds 4 allowed).
    Open

    func (store *WakuStore) Query(ctx context.Context, query Query, opts ...HistoryRequestOption) (*Result, error) {
    params := new(HistoryRequestParameters)
    params.s = store

    optList := DefaultOptions()
    Severity: Major
    Found in waku/v2/protocol/legacy_store/waku_store_client.go - About 55 mins to fix

      Method WakuStore.Find has 6 return statements (exceeds 4 allowed).
      Open

      func (store *WakuStore) Find(ctx context.Context, query Query, cb CriteriaFN, opts ...HistoryRequestOption) (*wpb.WakuMessage, error) {
    if cb == nil {
        return nil, errors.New("callback can't be null")
    }
      Severity: Major
      Found in waku/v2/protocol/legacy_store/waku_store_client.go - About 40 mins to fix

        Method WakuStore.queryFrom has 6 return statements (exceeds 4 allowed).
        Open

        func (store *WakuStore) queryFrom(ctx context.Context, historyRequest *pb.HistoryRPC, selectedPeer peer.ID) (*pb.HistoryResponse, error) {
    logger := store.log.With(logging.HostID("peer", selectedPeer))
    logger.Info("querying message history")

    stream, err := store.h.NewStream(ctx, selectedPeer, StoreID_v20beta4)
        Severity: Major
        Found in waku/v2/protocol/legacy_store/waku_store_client.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if store.pm != nil && params.peerAddr != nil {
            pData, err := store.pm.AddPeer(params.peerAddr, peerstore.Static, pubsubTopics, StoreID_v20beta4)
            if err != nil {
                return nil, err
            }
          Severity: Minor
          Found in waku/v2/protocol/legacy_store/waku_store_client.go and 1 other location - About 30 mins to fix
          waku/v2/protocol/store/client.go on lines 122..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status