Sign upLogin

waku-org/go-waku

View on GitHub
Star
waku/v2/rendezvous/db.go

Summary

Maintainability
B
5 hrs
Test Coverage
D
60%

Method DB.Discover has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (db *DB) Discover(ns string, cookie []byte, limit int) ([]dbi.RegistrationRecord, []byte, error) {
    now := time.Now().Unix()

    var (
        counter int64
Severity: Minor
Found in waku/v2/rendezvous/db.go - About 1 hr to fix

    Method DB.prepareStmts has 11 return statements (exceeds 4 allowed).
    Open

    func (db *DB) prepareStmts() error {
    stmt, err := db.db.Prepare("INSERT INTO registrations VALUES (NULL, ?, ?, ?, ?)")
    if err != nil {
        return err
    }
    Severity: Major
    Found in waku/v2/rendezvous/db.go - About 1 hr to fix

      Method DB.prepareStmts has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (db *DB) prepareStmts() error {
    stmt, err := db.db.Prepare("INSERT INTO registrations VALUES (NULL, ?, ?, ?, ?)")
    if err != nil {
        return err
    }
      Severity: Minor
      Found in waku/v2/rendezvous/db.go - About 1 hr to fix

        Method DB.Register has 5 return statements (exceeds 4 allowed).
        Open

        func (db *DB) Register(p peer.ID, ns string, signedPeerRecord []byte, ttl int) (uint64, error) {
    pid := p.String()
    expire := time.Now().Unix() + int64(ttl)

    tx, err := db.db.Begin()
        Severity: Major
        Found in waku/v2/rendezvous/db.go - About 35 mins to fix

          Method DB.Discover has 5 return statements (exceeds 4 allowed).
          Open

          func (db *DB) Discover(ns string, cookie []byte, limit int) ([]dbi.RegistrationRecord, []byte, error) {
    now := time.Now().Unix()

    var (
        counter int64
          Severity: Major
          Found in waku/v2/rendezvous/db.go - About 35 mins to fix

            Method DB.Discover has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
            Open

            func (db *DB) Discover(ns string, cookie []byte, limit int) ([]dbi.RegistrationRecord, []byte, error) {
    now := time.Now().Unix()

    var (
        counter int64
            Severity: Minor
            Found in waku/v2/rendezvous/db.go - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status