warlof/seat-discord-connector

View on GitHub
src/Driver/DiscordMember.php

Summary

Maintainability
A
35 mins
Test Coverage
A
96%

Function getSets has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getSets(): array
    {
        if ($this->roles->isEmpty()) {
            foreach ($this->role_ids as $role_id) {
                $set = DiscordClient::getInstance()->getSet($role_id);
Severity: Minor
Found in src/Driver/DiscordMember.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\Illuminate\Support\Str' in method 'setName'.
Open

        $nickname = Str::limit($name, Helper::NICKNAME_LENGTH_LIMIT, '');
Severity: Minor
Found in src/Driver/DiscordMember.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    private $id;
Severity: Minor
Found in src/Driver/DiscordMember.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $role_ids is not named in camelCase.
Open

class DiscordMember implements IUser
{
    /**
     * @var string
     */
Severity: Minor
Found in src/Driver/DiscordMember.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status