Sign upLogin

warlof/slackbot

View on GitHub
Star
src/Commands/SlackUserSync.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $group_ids = [];
        $filtered = false;
Severity: Minor
Found in src/Commands/SlackUserSync.php - About 1 hr to fix

    Add curly braces around the nested statement(s).
    Open

            if ($filtered)
    Severity: Critical
    Found in src/Commands/SlackUserSync.php by sonar-php

    While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

    Noncompliant Code Example

    if (condition)  // Noncompliant
  executeSomething();

    Compliant Solution

    if (condition) {
  executeSomething();
}

    See

    • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
    • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
    • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
    • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
    • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
    • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
    • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

    Add curly braces around the nested statement(s).
    Open

                    if ($user->groups->count() > 0)
    Severity: Critical
    Found in src/Commands/SlackUserSync.php by sonar-php

    While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

    Noncompliant Code Example

    if (condition)  // Noncompliant
  executeSomething();

    Compliant Solution

    if (condition) {
  executeSomething();
}

    See

    • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
    • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
    • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
    • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
    • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
    • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
    • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

    There are no issues that match your filters.

    Category
    Status