Sign upLogin

warlof/slackbot

View on GitHub
Star
src/Http/Controllers/SlackbotJsonController.php

Summary

Maintainability
D
1 day
Test Coverage

File SlackbotJsonController.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This file is part of slackbot and provide user synchronization between both SeAT and a Slack Team
 *
 * Copyright (C) 2016, 2017, 2018, 2019  Loïc Leuilliot <loic.leuilliot@gmail.com>
Severity: Minor
Found in src/Http/Controllers/SlackbotJsonController.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return $this->postTitleRelation($channelId, $corporationId, $titleId);
    Severity: Major
    Found in src/Http/Controllers/SlackbotJsonController.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->postAllianceRelation($channelId, $allianceId);
      Severity: Major
      Found in src/Http/Controllers/SlackbotJsonController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return redirect()->back()
                    ->with('error', 'Unknown relation type');
        Severity: Major
        Found in src/Http/Controllers/SlackbotJsonController.php - About 30 mins to fix

          Reduce the number of returns of this function 7, down to the maximum allowed 3.
          Open

              public function postRelation(AddRelation $request)
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

          Noncompliant Code Example

          With the default threshold of 3:

          function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

          Define a constant instead of duplicating this literal "alliance_id" 3 times.
          Open

                  $channelAlliance = SlackChannelAlliance::where('alliance_id', $alliance_id)
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "group_id" 3 times.
          Open

                  $channelUser = SlackChannelUser::where('group_id', $group_id)
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "channel" 6 times.
          Open

                  $channelPublic = SlackChannelPublic::with('channel')->get();
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Add curly braces around the nested statement(s).
          Open

                  if (is_null(setting('warlof.slackbot.credentials.access_token', true)))
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

          Noncompliant Code Example

          if (condition)  // Noncompliant
  executeSomething();

          Compliant Solution

          if (condition) {
  executeSomething();
}

          See

          • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
          • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
          • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
          • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
          • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
          • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
          • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

          Define a constant instead of duplicating this literal "This relation already exists" 6 times.
          Open

                      ->with('error', 'This relation already exists');
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "corporation_id" 8 times.
          Open

                  $corporationId = request()->input('corporation_id');
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "role_id" 3 times.
          Open

                  $channelRole = SlackChannelRole::where('role_id', $role_id)
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "title_id" 5 times.
          Open

                      $titles = CorporationTitle::where('corporation_id', $corporationId)->select('title_id', 'name')
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "enable" 6 times.
          Open

                          'enable' => true
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "channel_id" 17 times.
          Open

                  $channelPublic = SlackChannelPublic::where('channel_id', $channel_id);
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "success" 12 times.
          Open

                          ->with('success', 'The public slack relation has been removed');
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "error" 13 times.
          Open

                      ->with('error', 'An error occurs while trying to remove the public Slack relation.');
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Define a constant instead of duplicating this literal "corporation" 3 times.
          Open

                  $channelCorporations = SlackChannelCorporation::with('channel', 'corporation')->get();
          Severity: Critical
          Found in src/Http/Controllers/SlackbotJsonController.php by sonar-php

          Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

          On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

          Noncompliant Code Example

          With the default threshold of 3:

          function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

          Compliant Solution

          ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

          Exceptions

          To prevent generating some false-positives, literals having less than 5 characters are excluded.

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              private function postAllianceRelation($channelId, $allianceId)
    {
        $relation = SlackChannelAlliance::where('alliance_id', '=', $allianceId)
            ->where('channel_id', '=', $channelId)
            ->get();
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 2 hrs to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 285..304
          src/Http/Controllers/SlackbotJsonController.php on lines 306..325
          src/Http/Controllers/SlackbotJsonController.php on lines 327..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              private function postRoleRelation($channelId, $roleId)
    {
        $relation = SlackChannelRole::where('role_id', '=', $roleId)
            ->where('channel_id', '=', $channelId)
            ->get();
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 2 hrs to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 285..304
          src/Http/Controllers/SlackbotJsonController.php on lines 327..346
          src/Http/Controllers/SlackbotJsonController.php on lines 371..390

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              private function postGroupRelation($channelId, $groupId)
    {
        $relation = SlackChannelUser::where('channel_id', '=', $channelId)
            ->where('group_id', '=', $groupId)
            ->get();
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 2 hrs to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 306..325
          src/Http/Controllers/SlackbotJsonController.php on lines 327..346
          src/Http/Controllers/SlackbotJsonController.php on lines 371..390

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              private function postCorporationRelation($channelId, $corporationId)
    {
        $relation = SlackChannelCorporation::where('corporation_id', '=', $corporationId)
            ->where('channel_id', '=', $channelId)
            ->get();
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 2 hrs to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 285..304
          src/Http/Controllers/SlackbotJsonController.php on lines 306..325
          src/Http/Controllers/SlackbotJsonController.php on lines 371..390

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function removeAlliance($alliance_id, $channel_id)
    {
        $channelAlliance = SlackChannelAlliance::where('alliance_id', $alliance_id)
            ->where('channel_id', $channel_id);
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 40 mins to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 134..147
          src/Http/Controllers/SlackbotJsonController.php on lines 154..167
          src/Http/Controllers/SlackbotJsonController.php on lines 174..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function removeUser($group_id, $channel_id)
    {
        $channelUser = SlackChannelUser::where('group_id', $group_id)
            ->where('channel_id', $channel_id);
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 40 mins to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 154..167
          src/Http/Controllers/SlackbotJsonController.php on lines 174..187
          src/Http/Controllers/SlackbotJsonController.php on lines 216..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function removeRole($role_id, $channel_id)
    {
        $channelRole = SlackChannelRole::where('role_id', $role_id)
            ->where('channel_id', $channel_id);
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 40 mins to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 134..147
          src/Http/Controllers/SlackbotJsonController.php on lines 174..187
          src/Http/Controllers/SlackbotJsonController.php on lines 216..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              public function removeCorporation($corporation_id, $channel_id)
    {
        $channelCorporation = SlackChannelCorporation::where('corporation_id', $corporation_id)
            ->where('channel_id', $channel_id);
          Severity: Major
          Found in src/Http/Controllers/SlackbotJsonController.php and 3 other locations - About 40 mins to fix
          src/Http/Controllers/SlackbotJsonController.php on lines 134..147
          src/Http/Controllers/SlackbotJsonController.php on lines 154..167
          src/Http/Controllers/SlackbotJsonController.php on lines 216..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status