Sign upLogin

wasilak/cachego

View on GitHub
Star

Showing 4 of 4 total issues

Method BadgerCache.retrieveFromCache has 10 return statements (exceeds 4 allowed).
Open

func (c *BadgerCache) retrieveFromCache(cacheKey string) ([]byte, time.Time, error) {
    txn := c.Cache.NewTransaction(false)
    defer txn.Discard()

    var itemValue []byte
Severity: Major
Found in providers/badger.go - About 1 hr to fix

    Method BadgerCache.Set has 5 return statements (exceeds 4 allowed).
    Open

    func (c *BadgerCache) Set(cacheKey string, item []byte) error {
    _, span := c.Config.Tracer.Start(c.Config.CTX, "Set")
    defer span.End()

    // Serialize the ttl to bytes
    Severity: Major
    Found in providers/badger.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (c *BadgerCache) ExtendTTL(cacheKey string, item []byte) error {
    _, span := c.Config.Tracer.Start(c.Config.CTX, "ExtendTTL")
    defer span.End()

    c.Set(cacheKey, item)
      Severity: Minor
      Found in providers/badger.go and 1 other location - About 30 mins to fix
      providers/goCache.go on lines 91..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (c *GoCache) ExtendTTL(cacheKey string, item []byte) error {
    _, span := c.Config.Tracer.Start(c.Config.CTX, "ExtendTTL")
    defer span.End()

    c.Set(cacheKey, item)
      Severity: Minor
      Found in providers/goCache.go and 1 other location - About 30 mins to fix
      providers/badger.go on lines 140..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language