Sign upLogin

wavesoftware/puppet-xtreemfs

View on GitHub
Star

Showing 12 of 12 total issues

Class Xtfsutil has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Xtfsutil < Puppet::Provider

    # Puppet instances method, that fetches instances for CLI
    #
    # @return [Array] a list of +Puppet_X::Wavesoftware::Xtreemfs::Provider::Xtfsutil+
Severity: Minor
Found in lib/puppet_x/wavesoftware/xtreemfs/provider/xtfsutil.rb - About 2 hrs to fix

    Method directory_address has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.directory_address args
    unless [3,4].include? args.size
      raise(Puppet::ParseError, "directory_address(): Wrong number of arguments given (#{args.size} for 3..4)")
    end
    require 'uri'
    Severity: Minor
    Found in lib/puppet_x/wavesoftware/xtreemfs/functions/directory_address.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method options has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def options type
    opts = []
    if resource[:options]
      resource[:options].keys.sort.each do |key|
        value = resource[:options][key]
    Severity: Minor
    Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method uuid has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def uuid
    if @property_hash[:uuid]
      @property_hash[:uuid]
    else
      volumes = self.class.parse lsfs
    Severity: Minor
    Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method directory_address has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.directory_address args
    unless [3,4].include? args.size
      raise(Puppet::ParseError, "directory_address(): Wrong number of arguments given (#{args.size} for 3..4)")
    end
    require 'uri'
    Severity: Minor
    Found in lib/puppet_x/wavesoftware/xtreemfs/functions/directory_address.rb - About 1 hr to fix

      Method prefetch_one has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.prefetch_one file
    output = xtfsutil_cmd file
    propss, replicass = output.split(/Replicas:/)
    re = /(.+)\s{2,}(.+)/
    props = {}
      Severity: Minor
      Found in lib/puppet/provider/xtreemfs_replicate/xtfsutil.rb - About 1 hr to fix

        Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def validate
    if resource[:policy] != :none and resource[:factor] <= 1
      fail "A replication factor must be greater then 1"
    end
    unless File.exists? resource[:directory]
        Severity: Minor
        Found in lib/puppet/provider/xtreemfs_policy/xtfsutil.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method properties_to_augeas has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.properties_to_augeas args
    raise(Puppet::ParseError, "properies_to_augeas(): Wrong number of arguments " +
      "given (#{args.size} for 1..2)") if args.size != 1 and args.size != 2

    extra_hash = args[0]
        Severity: Minor
        Found in lib/puppet_x/wavesoftware/xtreemfs/functions/properties_to_augeas.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method rawinstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.rawinstances
    unless self.instances_raw
      fqdn = Facter.value :fqdn
      if self.is_port_open?(fqdn, 32636)
        volumes = lsfs_xtreemfs fqdn
        Severity: Minor
        Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def validate
    unless File.exists? resource[:file]
      fail "A file for replicate must exists, but it doesn't - #{resource[:file]}"
    end
    unless File.file? resource[:file]
        Severity: Minor
        Found in lib/puppet/provider/xtreemfs_replicate/xtfsutil.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            output.split("\n").each do |line|
      m = re.match line
      key = m[1].strip
      value = m[2].strip
      props[key] = value
        Severity: Minor
        Found in lib/puppet/provider/xtreemfs_policy/xtfsutil.rb and 1 other location - About 15 mins to fix
        lib/puppet/provider/xtreemfs_replicate/xtfsutil.rb on lines 20..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            propss.split("\n").each do |line|
      m = re.match line
      key = m[1].strip
      value = m[2].strip
      props[key] = value
        Severity: Minor
        Found in lib/puppet/provider/xtreemfs_replicate/xtfsutil.rb and 1 other location - About 15 mins to fix
        lib/puppet/provider/xtreemfs_policy/xtfsutil.rb on lines 18..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language