wbrefvem/corkboard

View on GitHub

Showing 212 of 212 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ($(this).closest("fieldset").hasClass("collapsed")) {
                // Show
                $(this).text(gettext("Hide")).closest("fieldset").removeClass("collapsed").trigger("show.fieldset", [$(this).attr("id")]);
            } else {
Severity: Major
Found in static/admin/js/collapse.js and 1 other location - About 1 hr to fix
static/admin/js/collapse.js on lines 17..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else {
                // Hide
                $(this).text(gettext("Show")).closest("fieldset").addClass("collapsed").trigger("hide.fieldset", [$(this).attr("id")]);
            }
Severity: Major
Found in static/admin/js/collapse.js and 1 other location - About 1 hr to fix
static/admin/js/collapse.js on lines 14..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function data has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    data: function( key, value ) {
        var attrs, name,
            elem = this[0],
            i = 0,
            data = null;
Severity: Minor
Found in static/admin/js/jquery.js - About 1 hr to fix

    Function cleanData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        cleanData: function( elems, /* internal */ acceptData ) {
            var elem, type, id, data,
                i = 0,
                internalKey = jQuery.expando,
                cache = jQuery.cache,
    Severity: Minor
    Found in static/admin/js/jquery.js - About 1 hr to fix

      Function style has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          style: function( elem, name, value, extra ) {
              // Don't set styles on text and comment nodes
              if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 || !elem.style ) {
                  return;
              }
      Severity: Minor
      Found in static/admin/js/jquery.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var clear_all = quickElement('a', selector_chosen, gettext('Remove all'), 'title', interpolate(gettext('Click to remove all chosen %s at once.'), [field_name]), 'href', 'javascript: (function() { SelectBox.move_all("' + field_id + '_to", "' + field_id + '_from"); SelectFilter.refresh_icons("' + field_id + '");})()', 'id', field_id + '_remove_all_link');
        Severity: Major
        Found in static/admin/js/SelectFilter2.js and 1 other location - About 1 hr to fix
        static/admin/js/SelectFilter2.js on lines 61..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var choose_all = quickElement('a', selector_available, gettext('Choose all'), 'title', interpolate(gettext('Click to choose all %s at once.'), [field_name]), 'href', 'javascript: (function(){ SelectBox.move_all("' + field_id + '_from", "' + field_id + '_to"); SelectFilter.refresh_icons("' + field_id + '");})()', 'id', field_id + '_add_all_link');
        Severity: Major
        Found in static/admin/js/SelectFilter2.js and 1 other location - About 1 hr to fix
        static/admin/js/SelectFilter2.js on lines 80..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Consider simplifying this complex logical expression.
        Open

                                } else if ( useCache && (cache = (elem[ expando ] || (elem[ expando ] = {}))[ type ]) && cache[0] === dirruns ) {
                                    diff = cache[1];
        
                                // xml :nth-child(...) or :nth-last-child(...) or :nth(-last)?-of-type(...)
                                } else {
        Severity: Critical
        Found in static/admin/js/jquery.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( jQuery.isFunction( value ) ) {
                      return this.each(function( j ) {
                          jQuery( this ).addClass( value.call( this, j, this.className ) );
                      });
                  }
          Severity: Major
          Found in static/admin/js/jquery.js and 1 other location - About 1 hr to fix
          static/admin/js/jquery.js on lines 2116..2120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( jQuery.isFunction( value ) ) {
                      return this.each(function( j ) {
                          jQuery( this ).removeClass( value.call( this, j, this.className ) );
                      });
                  }
          Severity: Major
          Found in static/admin/js/jquery.js and 1 other location - About 1 hr to fix
          static/admin/js/jquery.js on lines 2077..2081

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function setOffset has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              setOffset: function( elem, options, i ) {
                  var position = jQuery.css( elem, "position" );
          
                  // set position first, in-case top/left are set even on static elem
                  if ( position === "static" ) {
          Severity: Minor
          Found in static/admin/js/jquery.js - About 1 hr to fix

            Function fixCloneNodeIssues has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function fixCloneNodeIssues( src, dest ) {
                var nodeName, e, data;
            
                // We do not need to do anything for non-Elements
                if ( dest.nodeType !== 1 ) {
            Severity: Minor
            Found in static/admin/js/jquery.js - About 1 hr to fix

              Function attr has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  attr: function( elem, name, value ) {
                      var hooks, notxml, ret,
                          nType = elem.nodeType;
              
                      // don't get/set attributes on text, comment and attribute nodes
              Severity: Minor
              Found in static/admin/js/jquery.js - About 1 hr to fix

                Function load has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                jQuery.fn.load = function( url, params, callback ) {
                    if ( typeof url !== "string" && _load ) {
                        return _load.apply( this, arguments );
                    }
                
                
                Severity: Minor
                Found in static/admin/js/jquery.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var add_link = quickElement('a', quickElement('li', selector_chooser), gettext('Choose'), 'title', gettext('Choose'), 'href', 'javascript: (function(){ SelectBox.move("' + field_id + '_from","' + field_id + '_to"); SelectFilter.refresh_icons("' + field_id + '");})()', 'id', field_id + '_add_link');
                  Severity: Major
                  Found in static/admin/js/SelectFilter2.js and 1 other location - About 1 hr to fix
                  static/admin/js/SelectFilter2.js on lines 69..69

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var remove_link = quickElement('a', quickElement('li', selector_chooser), gettext('Remove'), 'title', gettext('Remove'), 'href', 'javascript: (function(){ SelectBox.move("' + field_id + '_to","' + field_id + '_from"); SelectFilter.refresh_icons("' + field_id + '");})()', 'id', field_id + '_remove_link');
                  Severity: Major
                  Found in static/admin/js/SelectFilter2.js and 1 other location - About 1 hr to fix
                  static/admin/js/SelectFilter2.js on lines 67..67

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function promise has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  jQuery.ready.promise = function( obj ) {
                      if ( !readyList ) {
                  
                          readyList = jQuery.Deferred();
                  
                  
                  Severity: Minor
                  Found in static/admin/js/jquery.js - About 1 hr to fix

                    Function addTimezoneWarning has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        addTimezoneWarning: function(inp) {
                            var $ = django.jQuery;
                            var warningClass = DateTimeShortcuts.timezoneWarningClass;
                            var timezoneOffset = DateTimeShortcuts.timezoneOffset / 3600;
                    
                    
                    Severity: Minor
                    Found in static/admin/js/admin/DateTimeShortcuts.js - About 1 hr to fix

                      Function handlers has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          handlers: function( event, handlers ) {
                              var sel, handleObj, matches, i,
                                  handlerQueue = [],
                                  delegateCount = handlers.delegateCount,
                                  cur = event.target;
                      Severity: Minor
                      Found in static/admin/js/jquery.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            dismissCalendar: function(num) {
                                document.getElementById(DateTimeShortcuts.calendarDivName1+num).style.display = 'none';
                                removeEvent(document, 'click', DateTimeShortcuts.dismissCalendarFunc[num]);
                            },
                        Severity: Major
                        Found in static/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 1 hr to fix
                        static/admin/js/admin/DateTimeShortcuts.js on lines 187..190

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language