Sign upLogin

weacast/weacast-client

View on GitHub
Star

Showing 33 of 33 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (fd === true) {
      // set the x pointer
      px = cx - r - sw * 0.5
      // set the y pointer
      py = cy
Severity: Major
Found in src/layers/leaflet-windbarb.js and 1 other location - About 1 day to fix
src/layers/leaflet-windbarb.js on lines 142..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 195.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (fd !== true) {
        // set the x pointer
        px = cx - r - sw * 0.5
        // set the y pointer
        py = cy
Severity: Major
Found in src/layers/leaflet-windbarb.js and 1 other location - About 1 day to fix
src/layers/leaflet-windbarb.js on lines 118..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 195.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _createBarbs has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _createBarbs: function (speed) {
    var s, b, bn, bw, bh, bs, sw, sl, p, r, w, h, cx, cy, xmlns, svg, g, fd
    // We expect speed in m/s and not knots
    s = speed / 0.514
    b = {5: 0, 10: 0, 50: 0}
Severity: Major
Found in src/layers/leaflet-windbarb.js - About 5 hrs to fix

    Function _createBarbs has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

      _createBarbs: function (speed) {
    var s, b, bn, bw, bh, bs, sw, sl, p, r, w, h, cx, cy, xmlns, svg, g, fd
    // We expect speed in m/s and not knots
    s = speed / 0.514
    b = {5: 0, 10: 0, 50: 0}
    Severity: Minor
    Found in src/layers/leaflet-windbarb.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getGeoJsonOptions has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        getGeoJsonOptions () {
      function htmlForProperties(feature, properties) {
        const borderStyle = ' style="border: 1px solid black; border-collapse: collapse;"'
        let html = '<table' + borderStyle + '>'
        html += '<tr' + borderStyle + '><th' + borderStyle + '><pre> Property </pre></th><th><pre>  Value  </pre></th></tr>'
    Severity: Minor
    Found in src/mixins/map/mixin.geojson-layers.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        } else {
      b.svg.style.transform = 'rotate(' + d + 'deg)'
      b.svg.style.MozTransform = 'rotate(' + d + 'deg)'
      b.svg.style.webkitTransform = 'rotate(' + d + 'deg)'
      b.svg.style.msTransform = 'rotate(' + d + 'deg)'
    Severity: Major
    Found in src/layers/leaflet-windbarb.js and 1 other location - About 3 hrs to fix
    src/layers/leaflet-windbarb.js on lines 295..300

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (this.options.mirrorVel) {
      b.svg.style.transform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.MozTransform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.webkitTransform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.msTransform = 'rotate(' + d + 'deg) scaleY(-1)'
    Severity: Major
    Found in src/layers/leaflet-windbarb.js and 1 other location - About 3 hrs to fix
    src/layers/leaflet-windbarb.js on lines 300..305

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getGeoJsonOptions has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getGeoJsonOptions () {
      function htmlForProperties(feature, properties) {
        const borderStyle = ' style="border: 1px solid black; border-collapse: collapse;"'
        let html = '<table' + borderStyle + '>'
        html += '<tr' + borderStyle + '><th' + borderStyle + '><pre> Property </pre></th><th><pre>  Value  </pre></th></tr>'
    Severity: Major
    Found in src/mixins/map/mixin.geojson-layers.js - About 3 hrs to fix

      Function initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initialize (api, options) {
    // Merge options with default for undefined ones
    this.options = Object.assign({
      interpolate: true,
      colorMap: 'OrRd',
      Severity: Major
      Found in src/layers/scalar-layer.js - About 2 hrs to fix

        File leaflet-windbarb.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
 (c) 2016, Manuel Bär (www.geonet.ch)
 Leaflet.WindBarbs, a wind barb plugin for Leaflet.
 This plugin enables the automatic creation of
 wind barb icons in Leaflet.
        Severity: Minor
        Found in src/layers/leaflet-windbarb.js - About 2 hrs to fix

          Function initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            initialize (api, options) {
    // Merge options with default for undefined ones
    const layerOptions = Object.assign({
      displayValues: true,
      displayOptions: {
          Severity: Minor
          Found in src/layers/flow-layer.js - About 1 hr to fix

            Function buildMesh has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            function buildMesh (gridView, colorMap, utils, container, opacity) {
  if ((gridView.size[0] * gridView.size[1]) > VERTEX_BUFFER_MAX_SIZE) {
    let subgridViews = gridView.cut()
    subgridViews.forEach(subgridView => buildMesh(subgridView, colorMap, utils, container, opacity))
  } else {
            Severity: Minor
            Found in src/layers/scalar-layer.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function buildMesh has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function buildMesh (gridView, colorMap, utils, container, opacity) {
  if ((gridView.size[0] * gridView.size[1]) > VERTEX_BUFFER_MAX_SIZE) {
    let subgridViews = gridView.cut()
    subgridViews.forEach(subgridView => buildMesh(subgridView, colorMap, utils, container, opacity))
  } else {
            Severity: Minor
            Found in src/layers/scalar-layer.js - About 1 hr to fix

              Function cut has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                cut () {
    let views = []
    if (this.size[0] >= this.size[1]) {
      views.push(new GridView({
        grid: this.grid,
              Severity: Minor
              Found in src/grid-viewer.js - About 1 hr to fix

                Function onEachFeature has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        onEachFeature: (feature, layer) => {
          const featureStyle = this.configuration.featureStyle
          // Custom defined function in component ?
          if (typeof this.getFeaturePopup === 'function') {
            layer.bindPopup(this.getFeaturePopup(feature, layer))
                Severity: Minor
                Found in src/mixins/map/mixin.geojson-layers.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        let x = gridView.grid.origin[0] + ((gridView.origin[0] + i) * gridView.grid.resolution[0]) + gridView.offset
                  Severity: Major
                  Found in src/layers/scalar-layer.js and 1 other location - About 1 hr to fix
                  src/layers/scalar-layer.js on lines 25..25

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          let x = gridView.grid.origin[0] + ((gridView.origin[0] + i) * gridView.grid.resolution[0]) + gridView.offset
                  Severity: Major
                  Found in src/layers/scalar-layer.js and 1 other location - About 1 hr to fix
                  src/layers/scalar-layer.js on lines 59..59

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function getViews has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    getViews () {
    let views = []
    if (this.grid.bounds[2] > 180) {
      let westSize = (this.grid.bounds[2] - 180) / this.grid.resolution[0]
      let eastSize = this.grid.size[0] - westSize
                  Severity: Minor
                  Found in src/grid-viewer.js - About 1 hr to fix

                    Function _setIconStyles has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      _setIconStyles: function (img, name, a) {
    var sw, r, anchor
    var options = this.options
    var size = L.point(options[name === 'shadow' ? 'shadowSize' : 'iconSize'])
    sw = this.options.strokeWidth
                    Severity: Minor
                    Found in src/layers/leaflet-windbarb.js - About 1 hr to fix

                      Function weacast has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export default function weacast () {
  let api = feathers()
  // Setup log level
  if (config.logs && config.logs.level) {
    logger.setLevel(config.logs.level, false)
                      Severity: Minor
                      Found in src/api.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language