Sign upLogin

weacast/weacast-client

View on GitHub
Star
src/layers/leaflet-windbarb.js

Summary

Maintainability
F
4 days
Test Coverage
F
0%

Function _createBarbs has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _createBarbs: function (speed) {
    var s, b, bn, bw, bh, bs, sw, sl, p, r, w, h, cx, cy, xmlns, svg, g, fd
    // We expect speed in m/s and not knots
    s = speed / 0.514
    b = {5: 0, 10: 0, 50: 0}
Severity: Major
Found in src/layers/leaflet-windbarb.js - About 5 hrs to fix

    Function _createBarbs has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

      _createBarbs: function (speed) {
    var s, b, bn, bw, bh, bs, sw, sl, p, r, w, h, cx, cy, xmlns, svg, g, fd
    // We expect speed in m/s and not knots
    s = speed / 0.514
    b = {5: 0, 10: 0, 50: 0}
    Severity: Minor
    Found in src/layers/leaflet-windbarb.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File leaflet-windbarb.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 (c) 2016, Manuel Bär (www.geonet.ch)
 Leaflet.WindBarbs, a wind barb plugin for Leaflet.
 This plugin enables the automatic creation of
 wind barb icons in Leaflet.
    Severity: Minor
    Found in src/layers/leaflet-windbarb.js - About 2 hrs to fix

      Function _setIconStyles has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _setIconStyles: function (img, name, a) {
    var sw, r, anchor
    var options = this.options
    var size = L.point(options[name === 'shadow' ? 'shadowSize' : 'iconSize'])
    sw = this.options.strokeWidth
      Severity: Minor
      Found in src/layers/leaflet-windbarb.js - About 1 hr to fix

        Function _setIconStyles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          _setIconStyles: function (img, name, a) {
    var sw, r, anchor
    var options = this.options
    var size = L.point(options[name === 'shadow' ? 'shadowSize' : 'iconSize'])
    sw = this.options.strokeWidth
        Severity: Minor
        Found in src/layers/leaflet-windbarb.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (fd === true) {
      // set the x pointer
      px = cx - r - sw * 0.5
      // set the y pointer
      py = cy
        Severity: Major
        Found in src/layers/leaflet-windbarb.js and 1 other location - About 1 day to fix
        src/layers/leaflet-windbarb.js on lines 142..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 195.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (fd !== true) {
        // set the x pointer
        px = cx - r - sw * 0.5
        // set the y pointer
        py = cy
        Severity: Major
        Found in src/layers/leaflet-windbarb.js and 1 other location - About 1 day to fix
        src/layers/leaflet-windbarb.js on lines 118..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 195.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            } else {
      b.svg.style.transform = 'rotate(' + d + 'deg)'
      b.svg.style.MozTransform = 'rotate(' + d + 'deg)'
      b.svg.style.webkitTransform = 'rotate(' + d + 'deg)'
      b.svg.style.msTransform = 'rotate(' + d + 'deg)'
        Severity: Major
        Found in src/layers/leaflet-windbarb.js and 1 other location - About 3 hrs to fix
        src/layers/leaflet-windbarb.js on lines 295..300

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (this.options.mirrorVel) {
      b.svg.style.transform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.MozTransform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.webkitTransform = 'rotate(' + d + 'deg) scaleY(-1)'
      b.svg.style.msTransform = 'rotate(' + d + 'deg) scaleY(-1)'
        Severity: Major
        Found in src/layers/leaflet-windbarb.js and 1 other location - About 3 hrs to fix
        src/layers/leaflet-windbarb.js on lines 300..305

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status