app/helpers/fae/form_helper.rb
module FaeModule has too many lines. [216/100]
Missing top-level module documentation comment. module FormHelperExtra empty line detected at module body beginning. Assignment Branch Condition size for fae_input is too high. [16.28/15]
Surrounding space missing in default value assignment. def fae_input(f, attribute, options={}) custom_options attribute, options language_support f, attribute, options label_and_hint attribute, options list_order f, attribute, options set_prompt f, attribute, options Line is too long. [83/80] add_input_class(options, 'js-markdown-editor') if options[:markdown].present? add_input_class(options, 'js-html-editor') if options[:html].present? Line is too long. [104/80] set_form_manager_container_attr(f, options, attribute) unless options[:show_form_manager] == false set_maxlength(f, attribute, options) f.input attribute, options end Surrounding space missing in default value assignment. def fae_association(f, attribute, options={}) custom_options attribute, options label_and_hint attribute, options list_order f, attribute, optionsFavor `unless` over `if` for negative conditions. set_prompt f, attribute, options if !options[:include_blank].is_a?(String) Line is too long. [104/80] set_form_manager_container_attr(f, options, attribute) unless options[:show_form_manager] == false f.association attribute, options end Surrounding space missing in default value assignment. def fae_prefix(f, attribute, options={})Line is too long. [123/80] raise "Fae::MissingRequiredOption: fae_prefix helper method requires the 'prefix' option." if options[:prefix].blank? symbol 'prefix', options[:prefix], options fae_input f, attribute, options end Surrounding space missing in default value assignment. def fae_suffix(f, attribute, options={})Line is too long. [123/80] raise "Fae::MissingRequiredOption: fae_suffix helper method requires the 'suffix' option." if options[:suffix].blank? symbol 'suffix', options[:suffix], options fae_input f, attribute, options end Surrounding space missing in default value assignment. def fae_radio(f, attribute, options={})Line is too long. [88/80] options[:alignment] = 'radio_collection--horizontal' if options[:type] == 'inline'Line is too long. [112/80] options[:alignment] = 'radio_collection--vertical' if options[:type] == 'stacked' || options[:type].blank?Line is too long. [131/80] options.update(as: :radio_collection, wrapper_class: "#{options[:wrapper_class]} #{options[:alignment]}", no_label_div: true) association_or_input f, attribute, options end Surrounding space missing in default value assignment. def fae_checkbox(f, attribute, options={}) options[:type] ||= 'stacked' options[:input_type] ||= :check_boxesLine is too long. [173/80] options.update(as: options[:input_type], wrapper_class: "input checkbox-wrapper js-checkbox-wrapper #{options[:wrapper_class]} -#{options[:type]}", no_label_div: true) association_or_input f, attribute, options end Assignment Branch Condition size for fae_pulldown is too high. [34.21/15]
Cyclomatic complexity for fae_pulldown is too high. [10/6]
Perceived complexity for fae_pulldown is too high. [10/7]
Method `fae_pulldown` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Surrounding space missing in default value assignment. def fae_pulldown(f, attribute, options={})Line is too long. [209/80]
Use `Hash#key?` instead of `Hash#has_key?`. raise "Fae::MissingRequiredOption: fae_pulldown requires a 'collection' when using it on an ActiveRecord attribute." if !options.has_key?(:collection) && f.object.attribute_names.include?(attribute.to_s)Use `%w` or `%W` for an array of words.
Space missing after comma.
Line is too long. [212/80] raise "Fae::ImproperOptionValue: The value #{options[:size]} is not a valid option for 'size'. Please use 'short' or 'long'." if options[:size].present? && ['short','long'].include?(options[:size]) == falseLine is too long. [198/80]
Avoid the use of double negation (`!!`). raise "Fae::ImproperOptionValue: The value #{options[:search]} is not a valid option for 'search'. Please use a Boolean." if options[:search].present? && !!options[:search] != options[:search] Prefer single-quoted strings when you don't need string interpolation or special symbols. add_input_class(options, 'small_pulldown') if options[:size] == "short" add_input_class(options, 'select-search') if options[:search]Line is too long. [111/80] options.update(wrapper_class: "#{options[:wrapper_class]} select-no_search") if options[:search] == false association_or_input f, attribute, options end Assignment Branch Condition size for fae_multiselect is too high. [18.44/15]
Surrounding space missing in default value assignment. def fae_multiselect(f, attribute, options={})Line is too long. [105/80]
Favor `unless` over `if` for negative conditions. raise "Fae::'#{attribute}' must be an association of #{f.object}" if !is_association?(f, attribute)Line is too long. [210/80]
Avoid the use of double negation (`!!`). raise "Fae::ImproperOptionValue: The value '#{options[:two_pane]}' is not a valid option for 'two_pane'. Please use a Boolean." if options[:two_pane].present? && !!options[:two_pane] != options[:two_pane] Line is too long. [103/80] options.update(input_class: "#{options[:input_class]} multiselect") if options[:two_pane] == true fae_association f, attribute, options end Surrounding space missing in default value assignment. def fae_datepicker(f, attribute, options={}) options.update(as: :string, wrapper_class: 'datepicker') fae_input f, attribute, options end Surrounding space missing in default value assignment. def fae_color_picker(f, attribute, options={}) options.update( as: :string,Line is too long. [102/80] input_class: "js-color-picker color-picker #{'alpha-slider' unless options[:alpha] == false}",Line is too long. [106/80] input_html: { value: f.object.send(attribute).to_s } # value needs to be set to clear color picker ) fae_input f, attribute, options end Surrounding space missing in default value assignment. def fae_daterange(f, attr_array, options={})Line is too long. [110/80] raise "Fae::MissingRequiredOption: fae_daterange requires the 'label' option." if options[:label].blank?Line is too long. [192/80] raise "Fae::MalformedArgument: fae_daterange requires an array of two attributes as it's second argument." unless attr_array.present? && attr_array.is_a?(Array) && attr_array.length == 2Line is too long. [96/80] options.update(as: :date_range, start_date: attr_array.first, end_date: attr_array.second) fae_input f, options[:label], options end Assignment Branch Condition size for fae_grouped_select is too high. [25.02/15]
Cyclomatic complexity for fae_grouped_select is too high. [8/6]
Perceived complexity for fae_grouped_select is too high. [8/7]
Surrounding space missing in default value assignment. def fae_grouped_select(f, attribute, options={})Prefer single-quoted strings when you don't need string interpolation or special symbols.
Use `Hash#key?` instead of `Hash#has_key?`.
Line is too long. [219/80] raise "Fae::MissingRequiredOption: fae_grouped_select requires a `collection` option or `groups` and `labels` options." if !options.has_key?(:collection) && !options.has_key?(:groups) && !options.has_key?(:labels)Line is too long. [208/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols. raise "Fae::MissingRequiredOption: fae_grouped_select required a `labels` option with a value containing an array when using the `groups` option." if options[:groups].present? && options[:labels].blank?Prefer single-quoted strings when you don't need string interpolation or special symbols.
Line is too long. [208/80] raise "Fae::MissingRequiredOption: fae_grouped_select required a `groups` option with a value containing an array when using the `labels` option." if options[:labels].present? && options[:groups].blank? Line is too long. [95/80] options[:collection] ||= group_options_for_collection(options[:labels], options[:groups])Line is too long. [114/80] options.update(as: :grouped_select, group_method: :last, wrapper_class: "#{options[:wrapper_class]} select") association_or_input f, attribute, options end Surrounding space missing in default value assignment. def fae_video_url(f, attribute, options={})Line is too long. [160/80] options[:helper_text] ||= "Please enter your YouTube video ID. The video ID is between v= and & of the video's url. This is typically 11 characters long." options[:hint] ||= '<div class="youtube-hint"></div>' fae_input f, attribute, options end Extra blank line detected. private Assignment Branch Condition size for custom_options is too high. [15.81/15]
Method `custom_options` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. def custom_options(attribute, options)Line is too long. [87/80] add_input_class(options, options[:input_class]) if options[:input_class].present? add_input_class(options, 'slug') if attribute == :slugLine is too long. [107/80] options.update(wrapper_class: "#{options[:wrapper_class]} input") if options[:wrapper_class].present?Line is too long. [102/80] options.update(validate: true) unless options[:validate].present? && options[:validate] == false end Assignment Branch Condition size for label_and_hint is too high. [31.7/15]
Cyclomatic complexity for label_and_hint is too high. [11/6]
Perceived complexity for label_and_hint is too high. [11/7]
Method has too many lines. [12/10]
Method `label_and_hint` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. def label_and_hint(attribute, options) hint = options[:hint] Line is too long. [99/80] options[:helper_text] = attempt_common_helper_text(attribute) if options[:helper_text].blank? Line is too long. [83/80] attribute_name = options[:as].to_s == 'hidden' ? '' : attribute.to_s.titleize label = options[:label] || label_translation(attribute) || attribute_name if options[:markdown_supported].present? || options[:helper_text].present? label += content_tag :h6, class: 'helper_text' doLine is too long. [120/80] concat(content_tag(:span, options[:helper_text], class: 'helper_text_text')) if options[:helper_text].present?Line is too long. [126/80] concat(content_tag(:span, 'Markdown Supported', class: 'markdown-support')) if options[:markdown_supported].present? end end options[:label] = label.html_safe if label.present? options[:hint] = hint.html_safe if hint.present? end def label_translation(attribute) try_translation attribute, 'fae.form.attribute' end def try_translation(item, translation_path) translation = t("#{translation_path}.#{item}") translation =~ /translation_missing/ ? nil : translation end Rename `is_attribute_or_association?` to `attribute_or_association?`. def is_attribute_or_association?(f, attribute) f.object.has_attribute?(attribute) || is_association?(f, attribute) end Rename `is_association?` to `association?`. def is_association?(f, attribute)Line is too long. [107/80] f.object.class.reflections.include?(attribute) || f.object.class.reflections.include?(attribute.to_s) end def association_or_input(f, attribute, options)Use a guard clause instead of wrapping the code inside a conditional expression. if is_attribute_or_association?(f, attribute)Line is too long. [133/80] f.object.attribute_names.include?(attribute.to_s) ? fae_input(f, attribute, options) : fae_association(f, attribute, options) else raise "Fae::undefined method '#{attribute}' for #{f.object}" end end def symbol(type, val, options) options[:as] = :symbolLine is too long. [143/80] options[:wrapper_class] = options[:wrapper_class].present? ? "#{options[:wrapper_class]} input symbol--#{type}" : "input symbol--#{type}" options[:span_class] = "input-symbol--#{type}" options[:span_class] += " icon-#{val}" if options[:icon].present? options[:content_text] = val if options[:icon].blank? end def group_options_for_collection(labels, groups)Prefer single-quoted strings when you don't need string interpolation or special symbols.
Line is too long. [103/80] raise "Fae::groups and labels must be an array" if !(labels.is_a? Array) || !(groups.is_a? Array)Line is too long. [165/80] raise "Fae::grouped options must be arrays of equal length. label length: #{labels.length}, options_length: #{groups.length}" if labels.length != groups.length collection = {} labels.each_with_index { |label, i| collection[label] = groups[i] } collection end def to_class(attribute) attribute.to_s.classify.constantize end Similar blocks of code found in 2 locations. Consider refactoring. def add_input_class(options, class_name) if options.key?(:input_html)Space inside } missing.
Line is too long. [93/80]
Space inside { missing.
Redundant curly braces around a hash parameter. options[:input_html].merge!({class: "#{options[:input_html][:class]} #{class_name}"}) else options[:input_html] = { class: class_name } end end Similar blocks of code found in 2 locations. Consider refactoring. def add_wrapper_class(options, class_name) if options.key?(:wrapper_html)Space inside { missing.
Line is too long. [97/80]
Redundant curly braces around a hash parameter.
Space inside } missing. options[:wrapper_html].merge!({class: "#{options[:wrapper_html][:class]} #{class_name}"}) else options[:wrapper_html] = { class: class_name } end end def set_form_manager_container_attr(f, options, attribute) form_manager_id = f.object.class.name form_manager_id = f.object.attached_as if f.object.try(:attached_as) form_manager_id += "_#{attribute}" if options.key?(:wrapper_html) options[:wrapper_html]['data-form-manager-id'] = form_manager_id else options[:wrapper_html] = { 'data-form-manager-id' => form_manager_id } end end # sets collection to class.for_fae_index if not defined def list_order(f, attribute, options)Use a guard clause instead of wrapping the code inside a conditional expression. if is_association?(f, attribute) && !options[:collection] begin options[:collection] = to_class(attribute).for_fae_index rescue NameErrorLine is too long. [131/80] raise "Fae::MissingCollection: `#{attribute}` isn't an orderable class, define your order using the `collection` option." end end end # sets default prompt for pulldowns def set_prompt(f, attribute, options)Line is too long. [185/80] options[:prompt] = 'None' if is_association?(f, attribute) && f.object.class.reflect_on_association(attribute).macro == :belongs_to && options[:prompt].nil? && !options[:two_pane] end # removes language suffix from label and adds data attr for languange navAssignment Branch Condition size for language_support is too high. [20.27/15]
Method has too many lines. [11/10]
Method `language_support` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Unused method argument - `f`. If it's necessary, use `_` or `_f` as an argument name to indicate that it won't be used. def language_support(f, attribute, options) return if Fae.languages.blank? attribute_array = attribute.to_s.split('_') language_suffix = attribute_array.popUse `Hash#key?` instead of `Hash#has_key?`.
Line is too long. [109/80] return unless Fae.languages.has_key?(language_suffix.to_sym) || Fae.languages.has_key?(language_suffix) label = attribute_array.push("(#{language_suffix})").join(' ').titleize options[:label] = label unless options[:label].present? if options[:wrapper_html].present?Line is too long. [83/80]
Redundant curly braces around a hash parameter. options[:wrapper_html].deep_merge!({ data: { language: language_suffix } }) else options[:wrapper_html] = { data: { language: language_suffix } } end end Assignment Branch Condition size for set_maxlength is too high. [18.17/15]
Method `set_maxlength` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. def set_maxlength(f, attribute, options) column = f.object.class.columns_hash[attribute.to_s]Line is too long. [94/80]
Use a guard clause instead of wrapping the code inside a conditional expression. if column.present? && (column.sql_type.include?('varchar') || column.sql_type == 'text') # Rails 4.1 supports column.limit, 4.2 supports column.cast_type.limit limit = column.try(:limit) || column.try(:cast_type).try(:limit) if limit.present? options[:input_html] ||= {} options[:input_html][:maxlength] ||= limit end end end def attempt_common_helper_text(attribute) case attribute when :seo_titleRedundant `return` detected.
Use 2 (not 1) spaces for indentation. return t('fae.seo_title') when :seo_descriptionUse 2 (not 1) spaces for indentation.
Redundant `return` detected. return t('fae.seo_description') elseUse 2 (not 1) spaces for indentation. '' end endExtra empty line detected at module body end. endend