Sign upLogin

wearefine/frob-core

View on GitHub
Star

Showing 18 of 18 total issues

Function factory has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var custom_breakpoints;
Severity: Minor
Found in source/javascripts/frob_core_helpers.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 288 lines of code (exceeds 25 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var custom_breakpoints;
Severity: Major
Found in source/javascripts/frob_core_helpers.js - About 1 day to fix

    Function factory has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    })(window, function factory(window) {
  'use strict';

  var defaults = {
    displayClass: 'shown',
    Severity: Minor
    Found in source/plugins/fcSuggest.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function factory has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    })(window, function factory(window) {
  'use strict';

  var defaults = {
    displayClass: 'shown',
    Severity: Major
    Found in source/plugins/fcSuggest.js - About 4 hrs to fix

      Function factory has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      })(window, function factory(window) {
  'use strict';


  var defaults = {
      Severity: Major
      Found in source/plugins/fcDropdown.js - About 3 hrs to fix

        Function init has 91 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function init(selector, options) {
    options = applyDefaults(options);

    var el = document.querySelectorAll(selector);
    // If we're given a greedy selector, initialize for all
        Severity: Major
        Found in source/plugins/fcSuggest.js - About 3 hrs to fix

          File frob_core_helpers.js has 300 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*!
 * FrobCoreHelpers v1.1
 * A framework for front (frob) enders (tenders) everywhere
 * MIT License
 */
          Severity: Minor
          Found in source/javascripts/frob_core_helpers.js - About 3 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            (function (window, factory) {
  'use strict';

  if (typeof define === 'function' && define.amd) {
    define([], factory(window));
            Severity: Major
            Found in source/plugins/fcDropdown.js and 2 other locations - About 2 hrs to fix
            source/javascripts/frob_core_helpers.js on lines 7..602
            source/plugins/fcSuggest.js on lines 3..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            (function (window, factory) {
  'use strict';

  if (typeof define === 'function' && define.amd) {
    define([], factory(window));
            Severity: Major
            Found in source/javascripts/frob_core_helpers.js and 2 other locations - About 2 hrs to fix
            source/plugins/fcDropdown.js on lines 3..220
            source/plugins/fcSuggest.js on lines 3..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            (function (window, factory) {
  'use strict';

  if (typeof define === 'function' && define.amd) {
    define([], factory(window));
            Severity: Major
            Found in source/plugins/fcSuggest.js and 2 other locations - About 2 hrs to fix
            source/javascripts/frob_core_helpers.js on lines 7..602
            source/plugins/fcDropdown.js on lines 3..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                for(var i = 0; i < default_keys.length; i++) {
      var key = default_keys[i];

      // If options does not have the default key, apply it
      if(!options.hasOwnProperty(key)) {
            Severity: Major
            Found in source/plugins/fcSuggest.js and 1 other location - About 2 hrs to fix
            source/javascripts/frob_core_helpers.js on lines 90..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 76.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                for(var i = 0; i < default_keys.length; i++) {
      var key = default_keys[i];

      // If options does not have the default key, apply it
      if(!options.hasOwnProperty(key)) {
            Severity: Major
            Found in source/javascripts/frob_core_helpers.js and 1 other location - About 2 hrs to fix
            source/plugins/fcSuggest.js on lines 36..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 76.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function FrobCoreHelpers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function FrobCoreHelpers(jsHolder, options) {
    options = this.setDefault(options, {});

    var dimensionsBreakpointsListener = this.screenSizes();
            Severity: Minor
            Found in source/javascripts/frob_core_helpers.js - About 1 hr to fix

              Function onKeyupFilter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function onKeyupFilter(e) {
      var suggestion;

      // Enter up down
      var is_special_action = [13, 38, 40].some(function(val) {
              Severity: Minor
              Found in source/plugins/fcSuggest.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    function dropDownOpen(destination) {
      var userOpen = settings.onOpen.call( this );

      if( userOpen !== false ) {
        FCH.addClass( this, settings.activeClass );
                Severity: Major
                Found in source/plugins/fcDropdown.js and 1 other location - About 1 hr to fix
                source/plugins/fcDropdown.js on lines 194..201

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    function dropDownClose(destination) {
      var userClose = settings.onClose.call( this );

      if( userClose !== false ) {
        FCH.removeClass( this, settings.activeClass );
                Severity: Major
                Found in source/plugins/fcDropdown.js and 1 other location - About 1 hr to fix
                source/plugins/fcDropdown.js on lines 208..215

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function onSpecialKeypress has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function onSpecialKeypress(keycode) {
      var active_element = list.querySelector( '.' + options.activeClass );
      var new_active_element = active_element;
      var shown_list = Array.prototype.slice.call( list.querySelectorAll( options.listSelector + '.' + options.displayClass ) );
      var active_index = shown_list.indexOf( active_element );
                Severity: Minor
                Found in source/plugins/fcSuggest.js - About 1 hr to fix

                  Function factory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  })(window, function factory(window) {
  'use strict';


  var defaults = {
                  Severity: Minor
                  Found in source/plugins/fcDropdown.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language