Sign upLogin

wearefine/frob-core

View on GitHub
Star
source/javascripts/frob_core_helpers.js

Summary

Maintainability
F
4 days
Test Coverage

Function factory has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var custom_breakpoints;
Severity: Minor
Found in source/javascripts/frob_core_helpers.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 288 lines of code (exceeds 25 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var custom_breakpoints;
Severity: Major
Found in source/javascripts/frob_core_helpers.js - About 1 day to fix

    File frob_core_helpers.js has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * FrobCoreHelpers v1.1
 * A framework for front (frob) enders (tenders) everywhere
 * MIT License
 */
    Severity: Minor
    Found in source/javascripts/frob_core_helpers.js - About 3 hrs to fix

      Function FrobCoreHelpers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function FrobCoreHelpers(jsHolder, options) {
    options = this.setDefault(options, {});

    var dimensionsBreakpointsListener = this.screenSizes();
      Severity: Minor
      Found in source/javascripts/frob_core_helpers.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        (function (window, factory) {
  'use strict';

  if (typeof define === 'function' && define.amd) {
    define([], factory(window));
        Severity: Major
        Found in source/javascripts/frob_core_helpers.js and 2 other locations - About 2 hrs to fix
        source/plugins/fcDropdown.js on lines 3..220
        source/plugins/fcSuggest.js on lines 3..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            for(var i = 0; i < default_keys.length; i++) {
      var key = default_keys[i];

      // If options does not have the default key, apply it
      if(!options.hasOwnProperty(key)) {
        Severity: Major
        Found in source/javascripts/frob_core_helpers.js and 1 other location - About 2 hrs to fix
        source/plugins/fcSuggest.js on lines 36..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status