Sign upLogin

wearefine/frob-core

View on GitHub
Star
source/plugins/fcSuggest.js

Summary

Maintainability
D
2 days
Test Coverage

Function factory has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var defaults = {
    displayClass: 'shown',
Severity: Minor
Found in source/plugins/fcSuggest.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

})(window, function factory(window) {
  'use strict';

  var defaults = {
    displayClass: 'shown',
Severity: Major
Found in source/plugins/fcSuggest.js - About 4 hrs to fix

    Function init has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function init(selector, options) {
    options = applyDefaults(options);

    var el = document.querySelectorAll(selector);
    // If we're given a greedy selector, initialize for all
    Severity: Major
    Found in source/plugins/fcSuggest.js - About 3 hrs to fix

      Function onKeyupFilter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function onKeyupFilter(e) {
      var suggestion;

      // Enter up down
      var is_special_action = [13, 38, 40].some(function(val) {
      Severity: Minor
      Found in source/plugins/fcSuggest.js - About 1 hr to fix

        Function onSpecialKeypress has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function onSpecialKeypress(keycode) {
      var active_element = list.querySelector( '.' + options.activeClass );
      var new_active_element = active_element;
      var shown_list = Array.prototype.slice.call( list.querySelectorAll( options.listSelector + '.' + options.displayClass ) );
      var active_index = shown_list.indexOf( active_element );
        Severity: Minor
        Found in source/plugins/fcSuggest.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          (function (window, factory) {
  'use strict';

  if (typeof define === 'function' && define.amd) {
    define([], factory(window));
          Severity: Major
          Found in source/plugins/fcSuggest.js and 2 other locations - About 2 hrs to fix
          source/javascripts/frob_core_helpers.js on lines 7..602
          source/plugins/fcDropdown.js on lines 3..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for(var i = 0; i < default_keys.length; i++) {
      var key = default_keys[i];

      // If options does not have the default key, apply it
      if(!options.hasOwnProperty(key)) {
          Severity: Major
          Found in source/plugins/fcSuggest.js and 1 other location - About 2 hrs to fix
          source/javascripts/frob_core_helpers.js on lines 90..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status