Sign upLogin

weareopensource/Swift

View on GitHub
Star

Showing 61 of 398 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: AuthSignUpReactor) {
        // cancel
        self.barButtonClose.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthSignupController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 146..167
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 81..102
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 75..96
waosSwift/modules/users/controllers/UserViewController.swift on lines 198..219

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: UserPreferenceReactor) {
        // cancel
        self.barButtonCancel.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/users/controllers/UserPreferenceController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 146..167
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 186..207
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 81..102
waosSwift/modules/users/controllers/UserViewController.swift on lines 198..219

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: TasksViewReactor) {
        // cancel
        self.barButtonCancel.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 146..167
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 186..207
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 75..96
waosSwift/modules/users/controllers/UserViewController.swift on lines 198..219

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: UserViewReactor) {
        // cancel
        self.barButtonCancel.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/users/controllers/UserViewController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 146..167
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 186..207
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 81..102
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 75..96

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: AuthForgotReactor) {
        // cancel
        self.barButtonClose.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthForgotController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 186..207
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 81..102
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 75..96
waosSwift/modules/users/controllers/UserViewController.swift on lines 198..219

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/users/controllers/UserController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/home/controllers/HomeTermsController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthSignupController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthSigninController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksListController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/users/controllers/UserViewController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/users/controllers/UserPreferenceController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/users/controllers/UserMoreController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/home/controllers/HomePageController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.errors.count }
            .distinctUntilChanged()
            .subscribe(onNext: { count in
                if(count > 0) {
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthSigninController.swift and 1 other location - About 1 hr to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 227..242

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.errors.count }
            .distinctUntilChanged()
            .subscribe(onNext: { count in
                if(count > 0) {
Severity: Major
Found in waosSwift/modules/auth/controllers/AuthForgotController.swift and 1 other location - About 1 hr to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 278..293

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func deleteAvatar() -> Observable<MyResult<UserResponse, CustomError>> {
        log.verbose("🔌 service : delete avatar ")
        return self.networking
            .request(.deleteAvatar)
            .map(UserResponse.self)
Severity: Major
Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
waosSwift/modules/users/services/UserService.swift on lines 35..47

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func me() -> Observable<MyResult<UserResponse, CustomError>> {
        log.verbose("🔌 service : me")
        return self.networking
            .request(.me)
            .map(UserResponse.self)
Severity: Major
Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
waosSwift/modules/users/services/UserService.swift on lines 104..116

Function viewDidLoad has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override func viewDidLoad() {
        self.view.setNeedsUpdateConstraints()
        // navigation
        if Metric.navigationBarTransparent == true {
            self.navigationController?.navigationBar.standardAppearance = self.transparentNavigationBar
Severity: Minor
Found in waosSwift/modules/core/controllers/CoreController.swift - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language