Sign upLogin

weavedev/store

View on GitHub
Star

Showing 8 of 8 total issues

Function watchWindowStoreSagas has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

export function watchWindowStoreSagas(run: SagaMiddleware['run']): void {
    // Map to store running sagas
    const storeSagas: Map<keyof StoreSagasMap, Task> = new Map();
    // Wrap window sagas object and copy existing sagas
    envGlobal.storeSagas = <StoreSagasMap>new Proxy(
Severity: Minor
Found in lib/sagas.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    interface Window {
        // Allows the use of Redux DevTools when true
        DEV_MODE: boolean;

        store: Store<StoreState, StoreActions>;
Severity: Major
Found in lib/init.ts and 1 other location - About 2 hrs to fix
lib/init.ts on lines 114..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        interface Process {
            // Allows the use of Redux DevTools when true
            DEV_MODE: boolean;

            store: Store<StoreState, StoreActions>;
Severity: Major
Found in lib/init.ts and 1 other location - About 2 hrs to fix
lib/init.ts on lines 101..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function watchWindowStoreReducers has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function watchWindowStoreReducers(): StoreReducer {
    // Place to keep removed reducer keys untill we are able to clean up when redux recalculates its store state
    let deletedReducers: StoreKey[] = [];
    // Constructed reducer
    let storeReducer: StoreReducer = combineReducers(envGlobal.storeReducers);
Severity: Minor
Found in lib/reducers.ts - About 1 hr to fix

    Function watchWindowStoreSagas has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function watchWindowStoreSagas(run: SagaMiddleware['run']): void {
    // Map to store running sagas
    const storeSagas: Map<keyof StoreSagasMap, Task> = new Map();
    // Wrap window sagas object and copy existing sagas
    envGlobal.storeSagas = <StoreSagasMap>new Proxy(
    Severity: Minor
    Found in lib/sagas.ts - About 1 hr to fix

      Function watchWindowStoreReducers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function watchWindowStoreReducers(): StoreReducer {
    // Place to keep removed reducer keys untill we are able to clean up when redux recalculates its store state
    let deletedReducers: StoreKey[] = [];
    // Constructed reducer
    let storeReducer: StoreReducer = combineReducers(envGlobal.storeReducers);
      Severity: Minor
      Found in lib/reducers.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (target[k] && storeSagas.has(k)) {
                    const existingSaga: Task | undefined = storeSagas.get(k);
                    if (existingSaga) {
                        existingSaga.cancel();
                    }
      Severity: Minor
      Found in lib/sagas.ts and 1 other location - About 30 mins to fix
      lib/sagas.ts on lines 17..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (storeSagas.has(k)) {
                    const existingSaga: Task | undefined = storeSagas.get(k);
                    if (existingSaga) {
                        existingSaga.cancel();
                    }
      Severity: Minor
      Found in lib/sagas.ts and 1 other location - About 30 mins to fix
      lib/sagas.ts on lines 33..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language