Sign upLogin

webionate/spree_paymill

View on GitHub
Star

Showing 2 of 2 total issues

Method update has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    if @order.update_attributes(object_params)

      fire_event('spree.checkout.update')
      # storing token in session to be able to use it when
Severity: Minor
Found in app/controllers/checkout_controller_decorator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authorize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def authorize(money, credit_card, options = {})
      init_data
      order = find_order(options)

      client = ::Paymill::Client.create(
Severity: Minor
Found in app/models/spree/payment_method/paymill.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language