Identical blocks of code found in 2 locations. Consider refactoring. Open
type UuidSaver func(reader io.Reader) (uuid string, err error)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 27.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
func newFileBoxUuid should be newFileBoxUUID Open
func newFileBoxUuid(uuid string) *fileBoxUuid {- Exclude checks
func SetUuidSaver should be SetUUIDSaver Open
func SetUuidSaver(saver UuidSaver) {- Exclude checks
type UuidLoader should be UUIDLoader Open
type UuidLoader func(uuid string) (io.Reader, error)- Exclude checks
type fileBoxUuid should be fileBoxUUID Open
type fileBoxUuid struct {- Exclude checks
func SetUuidLoader should be SetUUIDLoader Open
func SetUuidLoader(loader UuidLoader) {- Exclude checks
type UuidSaver should be UUIDSaver Open
type UuidSaver func(reader io.Reader) (uuid string, err error)- Exclude checks