wechaty/go-wechaty

View on GitHub
wechaty-puppet/helper/fix_unknown_message.go

Summary

Maintainability
B
6 hrs
Test Coverage
F
0%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        FinderColumn struct {
            Text   string `xml:",chardata"`
            CardId struct {
                Text string `xml:",chardata"`
            } `xml:"cardId"`
Severity: Major
Found in wechaty-puppet/helper/fix_unknown_message.go and 1 other location - About 1 hr to fix
wechaty-puppet/helper/fix_unknown_message.go on lines 94..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        Streamvideo struct {
            Text           string `xml:",chardata"`
            Streamvideourl struct {
                Text string `xml:",chardata"`
            } `xml:"streamvideourl"`
Severity: Major
Found in wechaty-puppet/helper/fix_unknown_message.go and 1 other location - About 1 hr to fix
wechaty-puppet/helper/fix_unknown_message.go on lines 457..483

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        Emotionpageshared struct {
            Text string `xml:",chardata"`
            Tid  struct {
                Text string `xml:",chardata"`
            } `xml:"tid"`
Severity: Major
Found in wechaty-puppet/helper/fix_unknown_message.go and 1 other location - About 1 hr to fix
wechaty-puppet/helper/fix_unknown_message.go on lines 406..426

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        Findernamecard struct {
            Text     string `xml:",chardata"`
            Username struct {
                Text string `xml:",chardata"`
            } `xml:"username"`
Severity: Major
Found in wechaty-puppet/helper/fix_unknown_message.go and 1 other location - About 1 hr to fix
wechaty-puppet/helper/fix_unknown_message.go on lines 211..231

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

struct field LocalId should be LocalID
Open

            LocalId struct {

struct field SecondUrl should be SecondURL
Open

            SecondUrl struct {

struct field ObjectNonceId should be ObjectNonceID
Open

            ObjectNonceId struct {

struct field ObjectNonceId should be ObjectNonceID
Open

            ObjectNonceId struct {

struct field PoiClassifyId should be PoiClassifyID
Open

                PoiClassifyId struct {

struct field JsAppId should be JsAppID
Open

            JsAppId struct {

struct field IconUrl3 should be IconURL3
Open

            IconUrl3 struct {

struct field JumpUrl should be JumpURL
Open

                JumpUrl struct {

struct field LiveMicSdkUserId should be LiveMicSdkUserID
Open

            LiveMicSdkUserId struct {

struct field CanvasPageXml should be CanvasPageXML
Open

            CanvasPageXml struct {

struct field ObjectNonceId should be ObjectNonceID
Open

                ObjectNonceId struct {

struct field ShareUrlOriginal should be ShareURLOriginal
Open

            ShareUrlOriginal struct {

struct field CardId should be CardID
Open

            CardId struct {

struct field IconUrl should be IconURL
Open

            IconUrl struct {

struct field ShareUrlOpen should be ShareURLOpen
Open

            ShareUrlOpen struct {

struct field PublisherId should be PublisherID
Open

            PublisherId struct {

struct field HeadUrl should be HeadURL
Open

            HeadUrl struct {

struct field IconUrl should be IconURL
Open

            IconUrl struct {

struct field ObjectNonceId should be ObjectNonceID
Open

                ObjectNonceId struct {

struct field IconUrl1 should be IconURL1
Open

            IconUrl1 struct {

struct field CoverUrl should be CoverURL
Open

            CoverUrl struct {

struct field CoverUrl should be CoverURL
Open

                CoverUrl struct {

struct field PatMusicId should be PatMusicID
Open

            PatMusicId struct {

struct field HeadUrl should be HeadURL
Open

            HeadUrl struct {

struct field LiveMicId should be LiveMicID
Open

            LiveMicId struct {

struct field ObjectId should be ObjectID
Open

                ObjectId struct {

struct field ObjectId should be ObjectID
Open

            ObjectId struct {

struct field ObjectId should be ObjectID
Open

                ObjectId struct {

struct field IconUrl should be IconURL
Open

                IconUrl struct {

struct field ObjectId should be ObjectID
Open

            ObjectId struct {

struct field IconUrl should be IconURL
Open

            IconUrl struct {

struct field IconUrl2 should be IconURL2
Open

            IconUrl2 struct {

There are no issues that match your filters.

Category
Status