Sign upLogin

wechaty/go-wechaty

View on GitHub
Star
wechaty/factory/tag.go

Summary

Maintainability
A
35 mins
Test Coverage
F
0%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (r *TagFactory) Load(id string) _interface.ITag {
    load, ok := r.pool.Load(id)
    if ok {
        return load.(*user.Tag)
    }
Severity: Minor
Found in wechaty/factory/tag.go and 1 other location - About 35 mins to fix
wechaty/factory/room.go on lines 97..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported method TagFactory.Load should have comment or be unexported
Open

func (r *TagFactory) Load(id string) _interface.ITag {
Severity: Minor
Found in wechaty/factory/tag.go by golint

exported method TagFactory.Delete should have comment or be unexported
Open

func (r *TagFactory) Delete(tag _interface.ITag) error {
Severity: Minor
Found in wechaty/factory/tag.go by golint

exported method TagFactory.Get should have comment or be unexported
Open

func (r *TagFactory) Get(tag string) _interface.ITag {
Severity: Minor
Found in wechaty/factory/tag.go by golint

exported type TagFactory should have comment or be unexported
Open

type TagFactory struct {
Severity: Minor
Found in wechaty/factory/tag.go by golint

There are no issues that match your filters.

Category
Status