Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star
appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java

Summary

Maintainability
D
1 day
Test Coverage

FastXmlSerializer has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

public class FastXmlSerializer implements XmlSerializer {
  private static final String ESCAPE_TABLE[] = new String[] {
      null,     null,     null,     null,     null,     null,     null,     null,  // 0-7
      null,     null,     null,     null,     null,     null,     null,     null,  // 8-15
      null,     null,     null,     null,     null,     null,     null,     null,  // 16-23
Severity: Minor
Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 4 hrs to fix

    File FastXmlSerializer.java has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (C) 2006 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 3 hrs to fix

      Method flush has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        public void flush() throws IOException {
    //Log.i("PackageManager", "flush mPos=" + mPos);
    if (mPos > 0) {
      if (mOutputStream != null) {
        CharBuffer charBuffer = CharBuffer.wrap(mText, 0, mPos);
      Severity: Minor
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method escapeAndAppendString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        private void escapeAndAppendString(final String string) throws IOException {
    final int N = string.length();
    final char NE = (char)ESCAPE_TABLE.length;
    final String[] escapes = ESCAPE_TABLE;
    int lastPos = 0;
      Severity: Minor
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method escapeAndAppendString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        private void escapeAndAppendString(char[] buf, int start, int len) throws IOException {
    final char NE = (char)ESCAPE_TABLE.length;
    final String[] escapes = ESCAPE_TABLE;
    int end = start+len;
    int lastPos = start;
      Severity: Minor
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setOutput has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        public void setOutput(OutputStream os, String encoding) throws IOException,
      IllegalArgumentException, IllegalStateException {
    if (os == null)
      throw new IllegalArgumentException();
    if (true) {
      Severity: Minor
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method endTag has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public XmlSerializer endTag(String namespace, String name) throws IOException,
      IllegalArgumentException, IllegalStateException {
    mNesting--;
    if (mInTag) {
      append(" />\n");
      Severity: Minor
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (length > BUFFER_LEN) {
      final int end = i + length;
      while (i < end) {
        int next = i + BUFFER_LEN;
        append(str, i, next<end ? BUFFER_LEN : (end-i));
      Severity: Major
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java and 1 other location - About 1 hr to fix
      appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java on lines 100..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (length > BUFFER_LEN) {
      final int end = i + length;
      while (i < end) {
        int next = i + BUFFER_LEN;
        append(buf, i, next<end ? BUFFER_LEN : (end-i));
      Severity: Major
      Found in appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java and 1 other location - About 1 hr to fix
      appframework/src/main/java/com/alibaba/weex/commons/util/FastXmlSerializer.java on lines 81..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status