weexteam/weex_devtools_android

View on GitHub
inspector/src/main/java/com/taobao/weex/devtools/common/android/ViewUtil.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method hitTestImpl has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  private static View hitTestImpl(
      View view,
      float x,
      float y,
      @Nullable Predicate<View> viewSelector,

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hitTestImpl has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private static View hitTestImpl(
      View view,
      float x,
      float y,
      @Nullable Predicate<View> viewSelector,

    Method hitTestImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          View view,
          float x,
          float y,
          @Nullable Predicate<View> viewSelector,
          boolean allowViewGroupResult) {

      Method isTransformedPointInView has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            ViewGroup parent,
            View child,
            float x,
            float y,
            @Nullable PointF outLocalPoint) {

        Avoid too many return statements within this method.
        Open

                    return childResult;

          Avoid too many return statements within this method.
          Open

              return allowViewGroupResult ? viewGroup : null;

            There are no issues that match your filters.

            Category
            Status