weexteam/weex_devtools_android

View on GitHub
inspector/src/main/java/com/taobao/weex/devtools/debug/DebugServerProxy.java

Summary

Maintainability
C
1 day
Test Coverage

Method start has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void start() {
        synchronized (DebugServerProxy.class) {
            if (mContext == null) {
                new IllegalArgumentException("Context is null").printStackTrace();
                return;

    File DebugServerProxy.java has 253 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.taobao.weex.devtools.debug;
    
    import android.content.Context;
    import android.content.Intent;
    import android.os.Build;

      Method handleRemoteRequest has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void handleRemoteRequest(JsonRpcPeer peer, JSONObject requestNode)
                  throws MessageHandlingException {
              JsonRpcRequest request;
              request = mObjectMapper.convertValue(
                      requestNode,

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    try {
                        responseString = jsonObject.toString();
                    } catch (OutOfMemoryError e) {
                        // JSONStringer can cause an OOM when the Json to handle is too big.
                        response.result = null;
        inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java on lines 144..152

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private static void logDispatchException(JsonRpcException e) {
                JsonRpcError errorMessage = e.getErrorMessage();
                switch (errorMessage.code) {
                    case METHOD_NOT_FOUND:
                        LogRedirector.d(TAG, "Method not implemented: " + errorMessage.message);
        inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java on lines 158..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
                    result = mMethodDispatcher.dispatch(peer,
                            request.method,
                            request.params);
                } catch (JsonRpcException e) {
        inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java on lines 129..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (messageNode.has("method")) {
                    handleRemoteRequest(peer, messageNode);
                } else if (messageNode.has("result")) {
                    handleRemoteResponse(peer, messageNode);
                } else {
        inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java on lines 111..117

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status