File Document.java
has 598 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* Copyright (c) 2014-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
Method findMatchingElements
has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring. Open
public void findMatchingElements(int x, int y, Accumulator<Integer> matchedIds) {
verifyThreadAccess();
final Object rootElement = mDocumentProvider.getRootElement();
final ElementInfo info = mShadowDocument.getElementInfo(rootElement);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Document
has 39 methods (exceeds 20 allowed). Consider refactoring. Open
public final class Document extends ThreadBoundProxy {
private final DocumentProviderFactory mFactory;
private final ObjectIdMapper mObjectIdMapper;
private final Queue<Object> mCachedUpdateQueue;
Method applyDocumentUpdate
has 79 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void applyDocumentUpdate(final ShadowDocument.Update docUpdate) {
// TODO: it'd be nice if we could delegate our calls into mPeerManager.sendNotificationToPeers()
// to a background thread so as to offload the UI from JSON serialization stuff
// First, any elements that have been disconnected from the tree, and any elements in those
Method updateListenerChildren
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
private static void updateListenerChildren(
ChildEventingList listenerChildren,
List<Object> newChildren,
Accumulator<Object> insertedElements) {
int index = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method findMatchingElements
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void findMatchingElements(int x, int y, Accumulator<Integer> matchedIds) {
verifyThreadAccess();
final Object rootElement = mDocumentProvider.getRootElement();
final ElementInfo info = mShadowDocument.getElementInfo(rootElement);
Method createShadowDocumentUpdate
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
private ShadowDocument.Update createShadowDocumentUpdate() {
verifyThreadAccess();
if (mDocumentProvider.getRootElement() != mShadowDocument.getRootElement()) {
throw new IllegalStateException();
Method updateListenerChildren
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static void updateListenerChildren(
ChildEventingList listenerChildren,
List<Object> newChildren,
Accumulator<Object> insertedElements) {
int index = 0;
Avoid deeply nested control flow statements. Open
for (int s = info.children.size(), j = s - 1; j >= 0; j--) {
final ElementInfo childInfo = mShadowDocument.getElementInfo(childElement);
if (childInfo != null) {
final Object child = childInfo.children.get(j);
if (child instanceof Activity) {
Method createShadowDocumentUpdate
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private ShadowDocument.Update createShadowDocumentUpdate() {
verifyThreadAccess();
if (mDocumentProvider.getRootElement() != mShadowDocument.getRootElement()) {
throw new IllegalStateException();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method findMatches
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private void findMatches(Object element, int x, int y, Accumulator<Integer> matchedIds, Boolean found) {
Method onChildNodeInserted
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
DocumentView view,
Object element,
int parentNodeId,
int previousNodeId,
Accumulator<Object> insertedItems) {
Method onChildNodeInserted
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
DocumentView view,
Object element,
int parentNodeId,
int previousNodeId,
Accumulator<Object> insertedItems);
Method doesElementMatch
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private boolean doesElementMatch(Object element, int x, int y) {
View view = null;
if (DOM.isNativeMode()) {
if (element instanceof View) {
view = (View)element;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 5 locations. Consider refactoring. Open
private AttributeListAccumulator acquireCachedAttributeAccumulator() {
AttributeListAccumulator accumulator = mCachedAttributeAccumulator;
if (accumulator == null) {
accumulator = new AttributeListAccumulator();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 41.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 5 locations. Consider refactoring. Open
private ArrayListAccumulator<Object> acquireChildrenAccumulator() {
ArrayListAccumulator<Object> accumulator = mCachedChildrenAccumulator;
if (accumulator == null) {
accumulator = new ArrayListAccumulator<>();
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 41.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76