Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java

Summary

Maintainability
C
7 hrs
Test Coverage

File CSS.java has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java - About 3 hrs to fix

    Method getMatchedStylesForNode has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @ChromeDevtoolsMethod
  public JsonRpcResult getMatchedStylesForNode(JsonRpcPeer peer, JSONObject params) {
    final GetMatchedStylesForNodeRequest request = mObjectMapper.convertValue(
        params,
        GetMatchedStylesForNodeRequest.class);
    Severity: Minor
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java - About 2 hrs to fix

      Method getComputedStyleForNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @ChromeDevtoolsMethod
  public JsonRpcResult getComputedStyleForNode(JsonRpcPeer peer, JSONObject params) {
    final GetComputedStyleForNodeRequest request = mObjectMapper.convertValue(
        params,
        GetComputedStyleForNodeRequest.class);
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private static class SourceRange {
    @JsonProperty(required = true)
    public int startLine;

    @JsonProperty(required = true)
        Severity: Major
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java and 2 other locations - About 40 mins to fix
        inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java on lines 187..199
        inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java on lines 335..347

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status