Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Page.java

Summary

Maintainability
B
6 hrs
Test Coverage

File Page.java has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Page.java - About 3 hrs to fix

    Page has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class Page implements ChromeDevtoolsDomain {
  private final Context mContext;
  private final ObjectMapper mObjectMapper = new ObjectMapper();

  @Nullable
    Severity: Minor
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Page.java - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public static class ScreencastFrameEventMetadata {
    @JsonProperty(required = true)
    public float pageScaleFactor;
    @JsonProperty(required = true)
    public int offsetTop;
      Severity: Major
      Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Page.java and 2 other locations - About 1 hr to fix
      inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java on lines 463..476
      inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java on lines 141..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status