Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java

Summary

Maintainability
D
1 day
Test Coverage

File Runtime.java has 451 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 6 hrs to fix

    Method objectForRemote has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public RemoteObject objectForRemote(Object value) {
      RemoteObject result = new RemoteObject();
      if (value == null) {
        result.type = ObjectType.OBJECT;
        result.subtype = ObjectSubType.NULL;
    Severity: Minor
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method objectForRemote has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public RemoteObject objectForRemote(Object value) {
      RemoteObject result = new RemoteObject();
      if (value == null) {
        result.type = ObjectType.OBJECT;
        result.subtype = ObjectSubType.NULL;
    Severity: Minor
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 1 hr to fix

      Method getPropertiesForObject has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private GetPropertiesResponse getPropertiesForObject(Object object) {
      GetPropertiesResponse response = new GetPropertiesResponse();
      List<PropertyDescriptor> properties = new ArrayList<>();
      for (
          Class<?> declaringClass = object.getClass();
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 1 hr to fix

        Method getPropertiesForObject has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private GetPropertiesResponse getPropertiesForObject(Object object) {
      GetPropertiesResponse response = new GetPropertiesResponse();
      List<PropertyDescriptor> properties = new ArrayList<>();
      for (
          Class<?> declaringClass = object.getClass();
        Severity: Minor
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public GetPropertiesResponse getProperties(JSONObject params) throws JsonRpcException {
      GetPropertiesRequest request = mObjectMapper.convertValue(params, GetPropertiesRequest.class);

      if (!request.ownProperties) {
        GetPropertiesResponse response = new GetPropertiesResponse();
        Severity: Minor
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return getPropertiesForProtoContainer((ObjectProtoContainer) object);
        Severity: Major
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return getPropertiesForIterable((List) object, /* enumerate */ true);
          Severity: Major
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              public static enum ObjectSubType {
    ARRAY("array"),
    NULL("null"),
    NODE("node"),
    REGEXP("regexp"),
            Severity: Minor
            Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Runtime.java and 1 other location - About 55 mins to fix
            inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Console.java on lines 55..77

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status