weexteam/weex_devtools_android

View on GitHub
inspector/src/main/java/com/taobao/weex/devtools/trace/DomTracker.java

Summary

Maintainability
D
2 days
Test Coverage

Method traverse has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

  @Nullable
  public HealthReport traverse() {
    long start = System.currentTimeMillis();
    if (Looper.getMainLooper() == Looper.myLooper()) {
      WXLogUtils.e(TAG, "illegal thread...");

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method traverse has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  @Nullable
  public HealthReport traverse() {
    long start = System.currentTimeMillis();
    if (Looper.getMainLooper() == Looper.myLooper()) {
      WXLogUtils.e(TAG, "illegal thread...");

    File DomTracker.java has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.taobao.weex.devtools.trace;
    
    import android.content.Context;
    import android.os.Looper;
    import android.support.annotation.NonNull;

      Method getRealDomMaxLayer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        private int getRealDomMaxLayer(@NonNull View rootView) {
          int maxLayer = 0;
          Deque<LayeredNode<View>> deque = new ArrayDeque<>();
          LayeredNode<View> rootNode = mRealDomObjectPool.obtain();
          rootNode.set(rootView,null,START_LAYER_OF_REAL_DOM);
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/trace/DomTracker.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getComponentNumOfNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        private int getComponentNumOfNode(@NonNull WXComponent rootNode) {
          Deque<WXComponent> deque = new ArrayDeque<>();
          deque.add(rootNode);
          int viewNum = 0;
          while (!deque.isEmpty()) {
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/trace/DomTracker.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status