weexteam/weex_devtools_android

View on GitHub
playground/app/src/androidTest/java/com/alibaba/weex/util/Falcon.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method takeBitmapUnchecked has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static Bitmap takeBitmapUnchecked(Activity activity) throws InterruptedException {
        final List<ViewRootData> viewRoots = getRootViews(activity);
        int statusBarHeight = ScreenShot.getStatusBarHeight1(activity);
        int actionBarHeight = ScreenShot.getActionBarHeight(activity);

    Method getRootViews has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SuppressWarnings("unchecked") // no way to check
        private static List<ViewRootData> getRootViews(Activity activity) {
            List<ViewRootData> rootViews = new ArrayList<>();
    
            Object globalWindowManager;

      Method takeScreenshot has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static void takeScreenshot(Activity activity, File toFile) {
              if (activity == null) {
                  throw new IllegalArgumentException("Parameter activity cannot be null.");
              }
      
      

        Method findField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static Field findField(String name, Class clazz) throws NoSuchFieldException {
                Class currentClass = clazz;
                while (currentClass != Object.class) {
                    for (Field field : currentClass.getDeclaredFields()) {
                        if (name.equals(field.getName())) {
        Severity: Minor
        Found in playground/app/src/androidTest/java/com/alibaba/weex/util/Falcon.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status