Function load
has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring. Open
public function load($resource, $type = null)
{
$routes = $this->loader->load($resource, $type);
if (!$routes instanceof RouteCollection) {
return $routes;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$name'. Open
foreach ($routes as $name => $route) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// If locale is already in the URL; we still need to add the new languages to the requirements
$this->addLanguagesToRequirements($route);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid excessively long variable names like $alreadyConfiguredLanguages. Keep variable name length under 20. Open
$alreadyConfiguredLanguages = explode('|', $route->getRequirement('_locale'));
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Arguments with default values must be at the end of the argument list Open
public function __construct(LoaderInterface $loader, array $locales = [], $defaultLocale)
- Exclude checks
Line exceeds 120 characters; contains 132 characters Open
* Trick du _S vu sur https://github.com/symfony/symfony/issues/9981 pour ne pas avoir la locale en langue originale dans l'URL.
- Exclude checks