Routing/Router.php
The method preGenerate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$request = $this->requestStack->getCurrentRequest();
$locale = $request === null ? $this->defaultLocale : $request->getLocale();
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused private methods such as 'postMatch'. Open
Open
private function postMatch(array $parameters = [])
{
if (!isset($parameters['_route']) || !isset($parameters['_locale'])) {
return $parameters;
}- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}