Twig/Extensions/LanguageCode.php
Missing class import via use statement (line '32', column '17'). Open
Open
new \Twig_SimpleFilter('language', [$this, 'languageFilter']),- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method languageFilter has a boolean flag argument $getEnglish, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function languageFilter($locale, $getEnglish = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}