Sign upLogin

werein/prestashop

View on GitHub
Star
lib/prestashop/mapper/models/product.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def initialize args = {}
        @id                         = args[:id]
        @id_manufacturer            = args[:id_manufacturer]
        @id_supplier                = args.fetch(:id_supplier)
        @id_category_default        = args[:id_category_default]
Severity: Major
Found in lib/prestashop/mapper/models/product.rb - About 2 hrs to fix

    Method hash has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def hash
        product = {
          id_supplier:          id_supplier,
          id_manufacturer:      id_manufacturer,
          id_category_default:  id_category_default,
    Severity: Minor
    Found in lib/prestashop/mapper/models/product.rb - About 1 hr to fix

      Method reference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def reference
        if @reference and not @reference.to_s.empty?
          @reference.to_s.length > 32 ? Digest::MD5.hexdigest(@reference) : @reference
        else
          Digest::MD5.hexdigest(name)
      Severity: Minor
      Found in lib/prestashop/mapper/models/product.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status