Sign upLogin

werf/werf

View on GitHub
Star
pkg/build/image/image.go

Summary

Maintainability
D
2 days
Test Coverage
F
57%

Method Image.SetupBaseImage has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (i *Image) SetupBaseImage(ctx context.Context, storageManager manager.StorageManagerInterface, storageOpts manager.StorageOptions) error {
    logboek.Context(ctx).Debug().LogF(" -- SetupBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case StageAsBaseImage:
Severity: Minor
Found in pkg/build/image/image.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Image has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

type Image struct {
    CommonImageOptions

    IsArtifact              bool
    IsDockerfileImage       bool
Severity: Minor
Found in pkg/build/image/image.go - About 3 hrs to fix

    Method Image.SetupBaseImage has 66 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (i *Image) SetupBaseImage(ctx context.Context, storageManager manager.StorageManagerInterface, storageOpts manager.StorageOptions) error {
    logboek.Context(ctx).Debug().LogF(" -- SetupBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case StageAsBaseImage:
    Severity: Minor
    Found in pkg/build/image/image.go - About 1 hr to fix

      Method Image.FetchBaseImage has 54 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (i *Image) FetchBaseImage(ctx context.Context) error {
    logboek.Context(ctx).Debug().LogF(" -- FetchBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case ImageFromRegistryAsBaseImage:
      Severity: Minor
      Found in pkg/build/image/image.go - About 1 hr to fix

        Method Image.FetchBaseImage has 8 return statements (exceeds 4 allowed).
        Open

        func (i *Image) FetchBaseImage(ctx context.Context) error {
    logboek.Context(ctx).Debug().LogF(" -- FetchBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case ImageFromRegistryAsBaseImage:
        Severity: Major
        Found in pkg/build/image/image.go - About 50 mins to fix

          Method Image.FetchBaseImage has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
          Open

          func (i *Image) FetchBaseImage(ctx context.Context) error {
    logboek.Context(ctx).Debug().LogF(" -- FetchBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case ImageFromRegistryAsBaseImage:
          Severity: Minor
          Found in pkg/build/image/image.go - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method Image.SetupBaseImage has 7 return statements (exceeds 4 allowed).
          Open

          func (i *Image) SetupBaseImage(ctx context.Context, storageManager manager.StorageManagerInterface, storageOpts manager.StorageOptions) error {
    logboek.Context(ctx).Debug().LogF(" -- SetupBaseImage for %q\n", i.Name)

    switch i.baseImageType {
    case StageAsBaseImage:
          Severity: Major
          Found in pkg/build/image/image.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if isUnsupportedMediaTypeError(err) {
                        if err := logboek.Context(ctx).Default().LogProcess("Pulling base image %s", i.baseStageImage.Image.Name()).
                            Options(func(options types.LogProcessOptionsInterface) {
                                options.Style(style.Highlight())
                            }).
            Severity: Major
            Found in pkg/build/image/image.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              if err != nil {
                    logboek.Context(ctx).Warn().LogF("WARNING: cannot get base image id (%s): %s\n", i.baseStageImage.Image.Name(), err)
                    logboek.Context(ctx).Warn().LogF("WARNING: using existing image %s without pull\n", i.baseStageImage.Image.Name())
                    logboek.Context(ctx).Warn().LogOptionalLn()
                } else {
              Severity: Major
              Found in pkg/build/image/image.go - About 45 mins to fix

                Method Image.setupBaseImageRepoDigest has 5 return statements (exceeds 4 allowed).
                Open

                func (i *Image) setupBaseImageRepoDigest(ctx context.Context, reference string) error {
    i.Conveyor.GetServiceRWMutex("baseImagesRepoIdsCache" + reference).Lock()
    defer i.Conveyor.GetServiceRWMutex("baseImagesRepoIdsCache" + reference).Unlock()

    switch {
                Severity: Major
                Found in pkg/build/image/image.go - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                          if err := logboek.Context(ctx).Default().LogProcess("Pulling base image %s", i.baseStageImage.Image.Name()).
                            Options(func(options types.LogProcessOptionsInterface) {
                                options.Style(style.Highlight())
                            }).
                            DoError(func() error {
                  Severity: Major
                  Found in pkg/build/image/image.go and 1 other location - About 1 hr to fix
                  pkg/build/image/image.go on lines 371..379

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 143.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if err := logboek.Context(ctx).Default().LogProcess("Pulling base image %s", i.baseStageImage.Image.Name()).
            Options(func(options types.LogProcessOptionsInterface) {
                options.Style(style.Highlight())
            }).
            DoError(func() error {
                  Severity: Major
                  Found in pkg/build/image/image.go and 1 other location - About 1 hr to fix
                  pkg/build/image/image.go on lines 272..280

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 143.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status