Sign upLogin

werf/werf

View on GitHub
Star
pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go

Summary

Maintainability
D
2 days
Test Coverage
C
78%

Method ExtraAnnotationsAndLabelsPostRenderer.Run has a Cognitive Complexity of 78 (exceeds 20 allowed). Consider refactoring.
Open

func (pr *ExtraAnnotationsAndLabelsPostRenderer) Run(renderedManifests *bytes.Buffer) (*bytes.Buffer, error) {
    extraAnnotations := map[string]string{}
    for k, v := range WerfRuntimeAnnotations {
        extraAnnotations[k] = v
    }
Severity: Minor
Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ExtraAnnotationsAndLabelsPostRenderer.Run has 104 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (pr *ExtraAnnotationsAndLabelsPostRenderer) Run(renderedManifests *bytes.Buffer) (*bytes.Buffer, error) {
    extraAnnotations := map[string]string{}
    for k, v := range WerfRuntimeAnnotations {
        extraAnnotations[k] = v
    }
Severity: Major
Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if err := appendExtraData(metadataNode, "annotations", extraAnnotations); err != nil {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf annotations won't be applied to the %s/%s: an error have occurred during annotations injection: %s\n", strings.ToLower(obj.GetKind()), obj.GetName(), err))
                    }
    Severity: Major
    Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if err := appendExtraData(metadataNode, "labels", extraLabels); err != nil {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf labels won't be applied to the %s/%s: an error have occurred during labels injection: %s\n", strings.ToLower(obj.GetKind()), obj.GetName(), err))
                    }
      Severity: Major
      Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if obj.IsList() && len(extraAnnotations) > 0 {
                    pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf annotations won't be applied to *List resource Kinds, including %s. We advise to replace *List resources with multiple separate resources of the same Kind", obj.GetKind()))
                } else if len(extraAnnotations) > 0 {
                    if err := appendExtraData(metadataNode, "annotations", extraAnnotations); err != nil {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf annotations won't be applied to the %s/%s: an error have occurred during annotations injection: %s\n", strings.ToLower(obj.GetKind()), obj.GetName(), err))
        Severity: Major
        Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go and 1 other location - About 1 hr to fix
        pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go on lines 311..317

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 151.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if obj.IsList() && len(extraLabels) > 0 {
                    pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf labels won't be applied to *List resource Kinds, including %s. We advise to replace *List resources with multiple separate resources of the same Kind", obj.GetKind()))
                } else if len(extraLabels) > 0 {
                    if err := appendExtraData(metadataNode, "labels", extraLabels); err != nil {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("werf labels won't be applied to the %s/%s: an error have occurred during labels injection: %s\n", strings.ToLower(obj.GetKind()), obj.GetName(), err))
        Severity: Major
        Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go and 1 other location - About 1 hr to fix
        pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go on lines 303..309

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 151.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if labelsNode := findNodeByKey(metadataNode, "labels"); labelsNode != nil {
                    validNodes, errors := validateMapStringStringNode(labelsNode)
                    for _, err := range errors {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("%s/%s labels validation: %s\n", strings.ToLower(obj.GetKind()), obj.GetName(), err.Error()))
                    }
        Severity: Minor
        Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go and 1 other location - About 50 mins to fix
        pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go on lines 319..327

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if annotationsNode := findNodeByKey(metadataNode, "annotations"); annotationsNode != nil {
                    validNodes, errors := validateMapStringStringNode(annotationsNode)
                    for _, err := range errors {
                        pr.globalWarnings.GlobalWarningLn(context.Background(), fmt.Sprintf("%s/%s annotations validation: %s", strings.ToLower(obj.GetKind()), obj.GetName(), err.Error()))
                    }
        Severity: Minor
        Found in pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go and 1 other location - About 50 mins to fix
        pkg/deploy/helm/extra_annotations_and_labels_post_renderer.go on lines 329..337

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status