Sign upLogin

werf/werf

View on GitHub
Star
pkg/true_git/patch.go

Summary

Maintainability
C
1 day
Test Coverage
D
61%

Function writePatch has 140 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func writePatch(ctx context.Context, out io.Writer, gitDir, workTreeCacheDir string, withSubmodules bool, opts PatchOptions) (*PatchDescriptor, error) {
    var err error

    gitDir, err = filepath.Abs(gitDir)
    if err != nil {
Severity: Major
Found in pkg/true_git/patch.go - About 4 hrs to fix

    Function writePatch has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
    Open

    func writePatch(ctx context.Context, out io.Writer, gitDir, workTreeCacheDir string, withSubmodules bool, opts PatchOptions) (*PatchDescriptor, error) {
    var err error

    gitDir, err = filepath.Abs(gitDir)
    if err != nil {
    Severity: Minor
    Found in pkg/true_git/patch.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function writePatch has 14 return statements (exceeds 4 allowed).
    Open

    func writePatch(ctx context.Context, out io.Writer, gitDir, workTreeCacheDir string, withSubmodules bool, opts PatchOptions) (*PatchDescriptor, error) {
    var err error

    gitDir, err = filepath.Abs(gitDir)
    if err != nil {
    Severity: Major
    Found in pkg/true_git/patch.go - About 1 hr to fix

      Function writePatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func writePatch(ctx context.Context, out io.Writer, gitDir, workTreeCacheDir string, withSubmodules bool, opts PatchOptions) (*PatchDescriptor, error) {
      Severity: Minor
      Found in pkg/true_git/patch.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status