Sign upLogin

wheely/ember-dialog

View on GitHub
Star

Showing 7 of 7 total issues

Function show has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  show(layout, template, context, options = {}, componentName = DEFAULT_COMPONENT_NAME) {

    /* Generate presenterId from (layoutName + templateName) or provided id
       to make sure the dialog won't open multiple times */
    var presenterId = options.id || "";
Severity: Minor
Found in addon/services/dialog.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      confirm(template, context, options, componentName = DEFAULT_COMPONENT_NAME) {
    const layout = Configuration["ember-dialog"].layoutPath + "/confirm";
    return this.show(layout, template, context, options, componentName);
  },
    Severity: Minor
    Found in addon/services/dialog.js and 1 other location - About 50 mins to fix
    addon/services/dialog.js on lines 422..425

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      blank(template, context, options, componentName = DEFAULT_COMPONENT_NAME) {
    const layout = Configuration["ember-dialog"].layoutPath + "/blank";
    return this.show(layout, template, context, options, componentName);
  }
    Severity: Minor
    Found in addon/services/dialog.js and 1 other location - About 50 mins to fix
    addon/services/dialog.js on lines 396..399

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      show(layout, template, context, options = {}, componentName = DEFAULT_COMPONENT_NAME) {

    /* Generate presenterId from (layoutName + templateName) or provided id
       to make sure the dialog won't open multiple times */
    var presenterId = options.id || "";
    Severity: Minor
    Found in addon/services/dialog.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function show has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      show(layout, template, context, options = {}, componentName = DEFAULT_COMPONENT_NAME) {
    Severity: Minor
    Found in addon/services/dialog.js - About 35 mins to fix

      Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        load(config) {
    let wrappedConfig = Ember.Object.create(config);
    for (let property in wrappedConfig) {
      if (wrappedConfig.hasOwnProperty(property)) {
        let value = get(wrappedConfig, property);
      Severity: Minor
      Found in addon/configuration.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function execAction(actionName, args) {
  const context = Ember.get(this, "contextObject");
  // @todo: Magic concatenation
  actionName = Ember.get(this, actionName + "Handler");
  args = makeArgsArray(args, this);
      Severity: Minor
      Found in addon/mixins/context.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language