lib/active_rest_client/validation.rb
Method valid?
has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring. Open
Open
def valid?
@errors = Hash.new {|h,k| h[k] = []}
self.class._validations.each do |validation|
value = self.send(validation[:field_name])
validation[:options].each do |type, options|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method valid?
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def valid?
@errors = Hash.new {|h,k| h[k] = []}
self.class._validations.each do |validation|
value = self.send(validation[:field_name])
validation[:options].each do |type, options|
Avoid deeply nested control flow statements. Open
Open
elsif type == :maximum && !value.nil?
@errors[validation[:field_name]] << "must be no more than #{options}" unless value.to_f <= options.to_f
Avoid deeply nested control flow statements. Open
Open
@errors[validation[:field_name]] << "must be at least #{options}" unless value.to_f >= options.to_f