src/Lingua/Iso_639_1Converter.php
Avoid using static access to class 'WhiteCube\Lingua\LanguagesRepository' in method 'parse'. Open
Open
$this->repository = LanguagesRepository::find('iso-639-1', $this->original);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The class Iso_639_1Converter is not named in CamelCase. Open
Open
class Iso_639_1Converter extends Converter implements ConverterInterface
{
public static function check($format)
{
if(preg_match('/^([A-Za-z]{2})$/', static::prepare($format))) return true;- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}